Use TransactionEditor in differential.createcomment
ClosedPublic
Actions

Authored by epriestley on Mar 7 2014, 8:04 PM.

Tags

None

Referenced Files

	F15427318: D8442.id20037.diff
	Sun, Mar 23, 1:45 PM

	F15425247: D8442.id20037.diff
	Sun, Mar 23, 3:31 AM

	F15334795: D8442.diff
	Sat, Mar 8, 12:11 PM

	F15333624: D8442.id20044.diff
	Sat, Mar 8, 3:33 AM

	Unknown Object (File)
	Feb 24 2025, 9:10 AM

	Unknown Object (File)
	Feb 23 2025, 5:33 PM

	Unknown Object (File)
	Feb 14 2025, 10:52 PM

	Unknown Object (File)
	Feb 14 2025, 10:52 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T2222: Implement ApplicationTransactions in Differential

Commits

Restricted Diffusion Commit
rP1c51ed594065: Use TransactionEditor in differential.createcomment

Summary

Ref T2222. Update this callsite; pretty straightforward.

Test Plan

Used Conduit to take actions and saw their effects in Differential.

Diff Detail

Repository

rP Phabricator

Branch

dx6

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/differential/query/DifferentialTransactionQuery.php:14	XHP16	TODO Comment

Unit

Tests Passed

Event Timeline

btrahan accepted this revision.Mar 8 2014, 12:26 AM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 8 2014, 12:26 AM

Closed by commit rP1c51ed594065 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

conduit/

ConduitAPI_differential_createcomment_Method.php

55 lines

controller/

DifferentialCommentSaveController.php

40 lines

query/

DifferentialTransactionQuery.php

35 lines

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

22 lines

Diff 20037

View Options

src/applications/differential/conduit/ConduitAPI_differential_createcomment_Method.php

View Options

src/applications/differential/controller/DifferentialCommentSaveController.php

View Options

src/applications/differential/query/DifferentialTransactionQuery.php

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Use TransactionEditor in differential.createcommentClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 20037

src/applications/differential/conduit/ConduitAPI_differential_createcomment_Method.php

src/applications/differential/controller/DifferentialCommentSaveController.php

src/applications/differential/query/DifferentialTransactionQuery.php

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Use TransactionEditor in differential.createcomment
ClosedPublic
Actions

Revision Contents
Changeset List