Page MenuHomePhabricator
Differential D8442

Use TransactionEditor in differential.createcomment
ClosedPublic
Actions

Authored by epriestley on Mar 7 2014, 8:04 PM.
Tags
None
Referenced Files
F17849206: D8442.diff
Sun, Jul 27, 8:23 AM
F17847882: D8442.diff
Sun, Jul 27, 6:40 AM
F17802540: D8442.id.diff
Fri, Jul 25, 9:12 AM
F17792812: D8442.id20037.diff
Thu, Jul 24, 10:55 PM
Unknown Object (File)
Sun, Jun 29, 5:58 AM
Unknown Object (File)
Sat, Jun 28, 9:18 PM
Unknown Object (File)
Jun 9 2025, 2:02 AM
Unknown Object (File)
May 25 2025, 6:28 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T2222: Implement ApplicationTransactions in Differential
Commits
Restricted Diffusion Commit
rP1c51ed594065: Use TransactionEditor in differential.createcomment
Summary

Ref T2222. Update this callsite; pretty straightforward.

Test Plan

Used Conduit to take actions and saw their effects in Differential.

Diff Detail

Repository
rP Phabricator
Branch
dx6
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/differential/query/DifferentialTransactionQuery.php:14XHP16TODO Comment
Unit
Tests Passed

Event Timeline

btrahan accepted this revision.Mar 8 2014, 12:26 AM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 8 2014, 12:26 AM
epriestley closed this revision.Mar 8 2014, 1:44 AM

Closed by commit rP1c51ed594065 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
conduit/
55 lines
controller/
40 lines
query/
35 lines
transactions/
editor/
22 lines

Diff 20037

View Options

src/applications/differential/conduit/ConduitAPI_differential_createcomment_Method.php

Loading...
View Options

src/applications/differential/controller/DifferentialCommentSaveController.php

Loading...
View Options

src/applications/differential/query/DifferentialTransactionQuery.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility