Ref T3886. Moves some of the "required" logic to the base class ("DifferentialCoreField") so Title and Test Plan can share it.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- Restricted Maniphest Task
- Commits
- Restricted Diffusion Commit
rP05f2ab32d8cc: Implement "Test Plan" as a CustomField
Edited revisions using "pro" editor, saw test plan transactions.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- dfield3
- Lint
Lint Passed - Unit
Tests Passed
Event Timeline
| src/applications/differential/customfield/DifferentialCoreCustomField.php | ||
|---|---|---|
| 25–30 | Nice. Surprised (sort of) PHP doesn't have something native to test this, and / or this hasn't made its way to libphutil yet. Mainly though I am writing this to validate relearning how come empty() is mostly useless. | |
Comment Actions
Yeah, maybe we should write phempty() which means "empty, except for strengths with nonzero string length, like "0"", although sometimes I think we want to call whitespace-only strings "empty" too and other times we don't. Maybe we could always call them "empty" without consequence though -- I can't think of cases offhand where " " is a legitimate nonempty value.