Page MenuHomePhabricator
Differential D8272

Modernize VCS password storage to use shared hash infrastructure
ClosedPublic
Actions

Authored by epriestley on Feb 18 2014, 8:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 15, 12:23 AM
Unknown Object (File)
Thu, Feb 13, 2:20 AM
Unknown Object (File)
Sun, Feb 9, 11:34 AM
Unknown Object (File)
Sun, Feb 9, 11:34 AM
Unknown Object (File)
Sun, Feb 9, 11:34 AM
Unknown Object (File)
Sun, Feb 9, 11:34 AM
Unknown Object (File)
Fri, Feb 7, 10:54 PM
Unknown Object (File)
Mon, Feb 3, 2:06 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T4443: Use bcrypt / password_hash() to hash passwords if available
Commits
Restricted Diffusion Commit
rPb96ab5aadf53: Modernize VCS password storage to use shared hash infrastructure
Summary

Fixes T4443. Plug VCS passwords into the shared key stretching. They don't use any real stretching now (I anticipated doing something like T4443 eventually) so we can just migrate them into stretching all at once.

Test Plan
  • Viewed VCS settings.
  • Used VCS password after migration.
  • Set VCS password.
  • Upgraded VCS password by using it.
  • Used VCS password some more.

Diff Detail

Repository
rP Phabricator
Branch
hashalg5
Lint
Lint Passed
Unit
Tests Passed

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
27 lines
src/
applications/
diffusion/
controller/
12 lines
panel/
20 lines
repository/
storage/
24 lines
settings/
panel/
25 lines
infrastructure/
util/
password/
36 lines

Diff 19680

View Options

resources/sql/autopatches/20140218.passwords.3.vcsextend.sql

Loading...
View Options

resources/sql/autopatches/20140218.passwords.4.vcs.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionServeController.php

Loading...
View Options

src/applications/diffusion/panel/DiffusionSetPasswordPanel.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryVCSPassword.php

Loading...
View Options

src/applications/settings/panel/PhabricatorSettingsPanelPassword.php

Loading...
View Options

src/infrastructure/util/password/PhabricatorPasswordHasher.php

Loading...
Phabricator · Built by Phacility