Differential D8264

Move many task status hardcodes into ManiphestTaskStatus
ClosedPublic
Actions

Authored by epriestley on Feb 17 2014, 9:00 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T1812: Allow for arbitrary values for task status

Commits

Restricted Diffusion Commit
rPf3cbc0e0066e: Move many task status hardcodes into ManiphestTaskStatus

Summary

Ref T1812. This cleans up most of the easy hard-coded references to specific statuses:

The "fixes" language moves into ManiphestTaskStatus.
Add a method to list open statuses.
Add a method to test if a status is open.
Add a method to get default status for new tasks.

Test Plan

Browsed around, lint, grep, created, filtered and updated tasks.

Diff Detail

Repository

rP Phabricator

Branch

diff4

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

btrahan accepted this revision.Feb 17 2014, 10:19 PM

Closed by commit rPf3cbc0e0066e (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

resources/

sql/

patches/

20130913.maniphest.1.migratesearch.php

7 lines

src/

applications/

differential/

field/

specification/

DifferentialFreeformFieldSpecification.php

40 lines

home/

controller/

PhabricatorHomeMainController.php

6 lines

maniphest/

application/

PhabricatorApplicationManiphest.php

2 lines

conduit/

ConduitAPI_maniphest_Method.php

2 lines

constants/

ManiphestTaskStatus.php

59 lines

controller/

ManiphestReportController.php

2 lines

field/

parser/

ManiphestCustomFieldStatusParser.php

34 lines

lipsum/

PhabricatorManiphestTaskTestDataGenerator.php

5 lines

mail/

ManiphestReplyHandler.php

2 lines

phid/

ManiphestPHIDTypeTask.php

2 lines

query/

ManiphestTaskSearchEngine.php

12 lines

search/

ManiphestSearchIndexer.php

2 lines

storage/

ManiphestTask.php

3 lines

project/

controller/

PhabricatorProjectBoardController.php

2 lines

PhabricatorProjectProfileController.php

2 lines

Diff 19654

View Options

resources/sql/patches/20130913.maniphest.1.migratesearch.php

View Options

src/applications/differential/field/specification/DifferentialFreeformFieldSpecification.php

View Options

src/applications/home/controller/PhabricatorHomeMainController.php

View Options

src/applications/maniphest/application/PhabricatorApplicationManiphest.php

View Options

src/applications/maniphest/conduit/ConduitAPI_maniphest_Method.php

View Options

src/applications/maniphest/constants/ManiphestTaskStatus.php

View Options

src/applications/maniphest/controller/ManiphestReportController.php

View Options

src/applications/maniphest/field/parser/ManiphestCustomFieldStatusParser.php

View Options

src/applications/maniphest/lipsum/PhabricatorManiphestTaskTestDataGenerator.php

View Options

src/applications/maniphest/mail/ManiphestReplyHandler.php

View Options

src/applications/maniphest/phid/ManiphestPHIDTypeTask.php

View Options

src/applications/maniphest/query/ManiphestTaskSearchEngine.php

View Options

src/applications/maniphest/search/ManiphestSearchIndexer.php

View Options

src/applications/maniphest/storage/ManiphestTask.php

View Options

src/applications/project/controller/PhabricatorProjectBoardController.php

View Options

src/applications/project/controller/PhabricatorProjectProfileController.php

Move many task status hardcodes into ManiphestTaskStatusClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 19654

resources/sql/patches/20130913.maniphest.1.migratesearch.php

src/applications/differential/field/specification/DifferentialFreeformFieldSpecification.php

src/applications/home/controller/PhabricatorHomeMainController.php

src/applications/maniphest/application/PhabricatorApplicationManiphest.php

src/applications/maniphest/conduit/ConduitAPI_maniphest_Method.php

src/applications/maniphest/constants/ManiphestTaskStatus.php

src/applications/maniphest/controller/ManiphestReportController.php

src/applications/maniphest/field/parser/ManiphestCustomFieldStatusParser.php

src/applications/maniphest/lipsum/PhabricatorManiphestTaskTestDataGenerator.php

src/applications/maniphest/mail/ManiphestReplyHandler.php

src/applications/maniphest/phid/ManiphestPHIDTypeTask.php

src/applications/maniphest/query/ManiphestTaskSearchEngine.php

src/applications/maniphest/search/ManiphestSearchIndexer.php

src/applications/maniphest/storage/ManiphestTask.php

src/applications/project/controller/PhabricatorProjectBoardController.php

src/applications/project/controller/PhabricatorProjectProfileController.php

Move many task status hardcodes into ManiphestTaskStatus
ClosedPublic
Actions

Revision Contents
Changeset List