Page MenuHomePhabricator
Differential D8192

Remove 'setShadow' from PHUIBoxView
ClosedPublic
Actions

Authored by chad on Feb 11 2014, 12:02 AM.
Tags
None
Referenced Files
F19314066: D8192.diff
Thu, Dec 25, 2:06 AM
F19072606: D8192.id.diff
Sun, Nov 30, 10:52 PM
F19063208: D8192.diff
Sat, Nov 29, 6:12 PM
F19001573: D8192.id18533.diff
Nov 21 2025, 3:43 AM
F18944191: D8192.id18532.diff
Nov 11 2025, 3:29 PM
F18944132: D8192.id18532.diff
Nov 11 2025, 3:22 PM
F18857374: D8192.id18532.diff
Nov 1 2025, 2:57 PM
F18844510: D8192.diff
Oct 29 2025, 5:54 AM
View All Files
Subscribers
aran
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP1ac28a7127be: Remove 'setShadow' from PHUIBoxView
Summary

Removes setShadow, uses setBorder instead

Test Plan

Tested multicolumn, feed, search box, many other areas. Things look less 3d.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Revision Contents
Changeset List

PathSize
resources/
celerity/
8 lines
src/
applications/
search/
controller/
2 lines
2 lines
uiexample/
examples/
8 lines
12 lines
10 lines
4 lines
4 lines
4 lines
view/
layout/
10 lines
phui/
9 lines
2 lines
webroot/
rsrc/
css/
aphront/
14 lines
phui/
11 lines

Diff 18533

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/search/controller/PhabricatorApplicationSearchController.php

Loading...
View Options

src/applications/search/controller/PhabricatorSearchController.php

Loading...
View Options

src/applications/uiexample/examples/PHUIBoxExample.php

Loading...
View Options

src/applications/uiexample/examples/PHUIIconExample.php

Loading...
View Options

src/applications/uiexample/examples/PHUIListExample.php

Loading...
View Options

src/applications/uiexample/examples/PHUITextExample.php

Loading...
View Options

src/applications/uiexample/examples/PhabricatorMultiColumnExample.php

Loading...
View Options

src/applications/uiexample/examples/PhabricatorUIStatusExample.php

Loading...
View Options

src/view/layout/AphrontMultiColumnView.php

Loading...
View Options

src/view/phui/PHUIBoxView.php

Loading...
View Options

src/view/phui/PHUIFeedStoryView.php

Loading...
View Options

webroot/rsrc/css/aphront/multi-column.css

Loading...
View Options

webroot/rsrc/css/phui/phui-box.css

Loading...
Phabricator · Built by Phacility