Page MenuHomePhabricator
Differential D8121

Allow ApplicationSearch to be offset-paged
ClosedPublic
Actions

Authored by epriestley on Jan 31 2014, 9:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 11, 2:17 PM
Unknown Object (File)
Tue, Sep 3, 9:48 AM
Unknown Object (File)
Thu, Aug 29, 10:29 AM
Unknown Object (File)
Mon, Aug 26, 1:06 PM
Unknown Object (File)
Sun, Aug 18, 3:37 AM
Unknown Object (File)
Sat, Aug 17, 8:30 AM
Unknown Object (File)
Fri, Aug 16, 3:57 AM
Unknown Object (File)
Fri, Aug 16, 3:57 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T4365: Use ApplicationSearch in primary search
Commits
Restricted Diffusion Commit
rPa82f57310230: Allow ApplicationSearch to be offset-paged
Summary

Ref T4365. It's not practical to cursor-page all engines; allow main search engines to be offset-paged. Basically, this comes down to setting a flag and then doing a couple of tiny things differently.

Test Plan

Used this two diffs from now.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Unknown Object (????).Jan 31 2014, 9:09 PM
  • Correct diff.
btrahan accepted this revision.Feb 1 2014, 9:56 PM
epriestley closed this revision.Feb 3 2014, 8:52 PM

Closed by commit rPa82f57310230 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
search/
controller/
27 lines
engine/
2 lines
index/
11 lines
view/
control/
11 lines

Diff 18405

View Options

src/applications/search/controller/PhabricatorApplicationSearchController.php

Loading...
View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...
View Options

src/applications/search/index/PhabricatorSearchIndexer.php

Loading...
View Options

src/view/control/AphrontPagerView.php

Loading...
Phabricator · Built by Phacility