Page MenuHomePhabricator

Fix two bugs with DraggableList
ClosedPublic

Authored by epriestley on Jan 12 2014, 10:51 PM.
Tags
None
Referenced Files
F13190715: D7939.id17981.diff
Sat, May 11, 1:14 PM
F13190714: D7939.id17960.diff
Sat, May 11, 1:14 PM
F13190478: D7939.id.diff
Sat, May 11, 11:21 AM
F13190429: D7939.diff
Sat, May 11, 10:57 AM
F13188890: D7939.diff
Sat, May 11, 5:34 AM
Unknown Object (File)
Tue, May 7, 7:54 AM
Unknown Object (File)
Mon, May 6, 4:29 PM
Unknown Object (File)
Sun, May 5, 1:26 PM
Subscribers

Details

Summary

Ref T1344. This fixes two issues with DraggableList:

  • In lists which allowed it, you could drag the top item above itself and get a dashed-border ghost item. This didn't make sense and didn't behave well. Just don't treat this operation as valid.
  • In lists which allowed it, you could drag any non-top item to the topmost position, then drag it to an invalid position. The dashed-border ghost item would not be removed properly if this happend.
  • Also fix some minor leftovers with Celerity.
Test Plan
  • Dragged the first item above itself; now an invalid operation with no ghost.
  • Dragged another item to the first position then back to its original position; ghost vanishes.
  • Clean lint.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

webroot/rsrc/js/core/DraggableList.js
162–165

Note this for null vs false trickiness.

I tried to make a good joke about null, but I kept coming up false. (See how bad that was?)