This adds in the create flow for the Project board columns on the super secret board page which totally doesn't do anything right now.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T1344: Create the ability to show a Trello style view for projects.
- Commits
- Restricted Diffusion Commit
rP5417f91b77f7: Adding the create flow for Project Board (Workphlow) columns.
- Apply diff.
- Go to super secret page.
- Click link close to top with a way too long name.
- Enter a name for the column.
- Enjoy a new column briefly before realising you cannot remove it.
- Stay happy!
Diff Detail
Diff Detail
- Branch
- board_columns
- Lint
Lint Warnings Excuse: Linting on SQL? That's just mean! Severity Location Code Message Warning resources/sql/autopatches/20140109.projectcolumnsdates.sql:1 TXT3 Line Too Long Warning resources/sql/autopatches/20140109.projectcolumnsdates.sql:2 TXT3 Line Too Long Warning src/applications/project/controller/PhabricatorProjectBoardEditController.php:81 TXT3 Line Too Long Advice src/applications/project/controller/PhabricatorProjectBoardEditController.php:35 XHP16 TODO Comment - Unit
No Unit Test Coverage
Event Timeline
Comment Actions
Some very minor nits inline, but I'll just clean those up in the pull. This looks great to me, thanks! Let me know when you're ready for the next piece.
| resources/sql/autopatches/20140109.projectcolumnsdates.sql | ||
|---|---|---|
| 1–2 | For consistency, linebreak these as: ALTER TABLE ... ADD ... | |
| src/applications/project/controller/PhabricatorProjectBoardEditController.php | ||
| 42 | (Unused.) | |
| 102 | We aren't totally consistent about this, but by convention don't link the last crumb (i.e., omit $request->getRequestURI()). We should also maybe put more crumbs here, like: [Projects] > Project Name > Board > Create Column ...but we can fill that in later. | |