Page MenuHomePhabricator

Adding the create flow for Project Board (Workphlow) columns.
ClosedPublic

Authored by mikn on Jan 9 2014, 9:58 PM.

Details

Summary

This adds in the create flow for the Project board columns on the super secret board page which totally doesn't do anything right now.

Test Plan
  1. Apply diff.
  2. Go to super secret page.
  3. Click link close to top with a way too long name.
  4. Enter a name for the column.
  5. Enjoy a new column briefly before realising you cannot remove it.
  6. Stay happy!

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

Some very minor nits inline, but I'll just clean those up in the pull. This looks great to me, thanks! Let me know when you're ready for the next piece.

resources/sql/autopatches/20140109.projectcolumnsdates.sql
1–2

For consistency, linebreak these as:

ALTER TABLE ...
  ADD ...
src/applications/project/controller/PhabricatorProjectBoardEditController.php
42

(Unused.)

102

We aren't totally consistent about this, but by convention don't link the last crumb (i.e., omit $request->getRequestURI()).

We should also maybe put more crumbs here, like:

[Projects] > Project Name > Board > Create Column

...but we can fill that in later.

Closed by commit rP5417f91b77f7 (authored by @mikn, committed by @epriestley).