Page MenuHomePhabricator

Clean up AphrontError boxes, Diffusion Headers
ClosedPublic

Authored by chad on Jan 9 2014, 4:24 AM.
Tags
None
Referenced Files
F17650537: D7914.id17922.diff
Sat, Jul 12, 4:45 AM
F17637059: D7914.id.diff
Fri, Jul 11, 1:16 PM
F17636416: D7914.id17912.diff
Fri, Jul 11, 10:54 AM
F17624813: D7914.diff
Thu, Jul 10, 2:25 AM
Unknown Object (File)
May 29 2025, 5:42 AM
Unknown Object (File)
May 8 2025, 5:12 AM
Unknown Object (File)
Apr 30 2025, 5:33 AM
Unknown Object (File)
Apr 17 2025, 7:21 AM

Details

Summary

Two basic changes here, first we fixed up the Diffusion headers to roll out more PHUIObjectBoxes. Second we added some specific styles for when Errors are inside an ObjectBox at the first position.

Test Plan

Tested a number of different layouts for browsing respositories as well as wherever I could find cases with PHUIObjectBox Form Errors (see images attached). Still some minor tightening due after this diff, but didnt want to overload it.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

{F100141}

{F100142}

{F100143}

{F100144}

{F100145}

Also, I seem to be stuck at importing.. haha.. need to troubleshoot that.