Page MenuHomePhabricator

Clean up AphrontError boxes, Diffusion Headers

Authored by chad on Jan 9 2014, 4:24 AM.



Two basic changes here, first we fixed up the Diffusion headers to roll out more PHUIObjectBoxes. Second we added some specific styles for when Errors are inside an ObjectBox at the first position.

Test Plan

Tested a number of different layouts for browsing respositories as well as wherever I could find cases with PHUIObjectBox Form Errors (see images attached). Still some minor tightening due after this diff, but didnt want to overload it.

Diff Detail

Lint Skipped
Tests Skipped

Event Timeline






Also, I seem to be stuck at importing.. haha.. need to troubleshoot that.