Paths

Table of Contentst

Skip unit tests if `ArcanistLinter::getCacheVersion` throws an `ArcanistUsageException`
ClosedPublic
Actions

Authored by joshuaspence on Jan 9 2014, 1:56 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 25, 1:40 AM

	Unknown Object (File)
	Thu, Nov 21, 4:00 PM

	Unknown Object (File)
	Sun, Nov 17, 1:31 PM

	Unknown Object (File)
	Wed, Nov 13, 3:29 AM

	Unknown Object (File)
	Sun, Nov 10, 8:17 AM

	Unknown Object (File)
	Oct 24 2024, 2:07 PM

	Unknown Object (File)
	Oct 19 2024, 7:45 AM

	Unknown Object (File)
	Oct 17 2024, 8:25 PM

Subscribers

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4288: Unit test is not skipped if ArcanistLinter::getCacheVersion throws an ArcanistUsageException

Commits

rARCef598794a812: Skip unit tests if `ArcanistLinter::getCacheVersion` throws an…

Summary

Fixes T4288

Test Plan

N/A

Diff Detail

Branch

external_linter

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

Can you throw a comment in the catch block about why/when this happens?

Also, walk me through how this causes the tests to be skipped? That doesn't seem to follow obviously from this change...

Yeah sorry, that was a really bad attempt. Pushing a new diff

Previous attempt didn't work as expected.

joshuaspence added inline comments.Jan 9 2014, 2:19 AM

src/lint/linter/__tests__/ArcanistLinterTestCase.php
122 ↗	(On Diff #17911)	`ArcanistLinter::getCacheVersion` throws `ArcanistUsageException`... it doesn't get converted into a `PhutilAggregateException`.

Ah, nice, this is much cleaner.

Closed by commit rARCef598794a812 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

lint/

engine/

ArcanistLintEngine.php

6 lines

Diff 17910

View Options

src/lint/engine/ArcanistLintEngine.php

Skip unit tests if `ArcanistLinter::getCacheVersion` throws an `ArcanistUsageException`ClosedPublicActions