Page MenuHomePhabricator
Differential D7913

Skip unit tests if `ArcanistLinter::getCacheVersion` throws an `ArcanistUsageException`
ClosedPublic
Actions

Authored by joshuaspence on Jan 9 2014, 1:56 AM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4288: Unit test is not skipped if ArcanistLinter::getCacheVersion throws an ArcanistUsageException
Commits
rARCef598794a812: Skip unit tests if `ArcanistLinter::getCacheVersion` throws an…
Summary

Fixes T4288

Test Plan

N/A

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley added a comment.Jan 9 2014, 1:59 AM

Can you throw a comment in the catch block about why/when this happens?

Also, walk me through how this causes the tests to be skipped? That doesn't seem to follow obviously from this change...

joshuaspence added a comment.Jan 9 2014, 2:18 AM

Yeah sorry, that was a really bad attempt. Pushing a new diff

joshuaspence updated this revision to Unknown Object (????).Jan 9 2014, 2:18 AM

Previous attempt didn't work as expected.

joshuaspence added inline comments.Jan 9 2014, 2:19 AM
src/lint/linter/__tests__/ArcanistLinterTestCase.php
122

ArcanistLinter::getCacheVersion throws ArcanistUsageException... it doesn't get converted into a PhutilAggregateException.

epriestley accepted this revision.Jan 9 2014, 5:25 PM

Ah, nice, this is much cleaner.

epriestley closed this revision.Jan 9 2014, 5:25 PM

Closed by commit rARCef598794a812 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
__tests__/
2 lines

Diff 17923

View Options

src/lint/linter/__tests__/ArcanistLinterTestCase.php

Loading...
Phabricator · Built by Phacility