Use radio buttons with explanatory text to select commit rule types
ClosedPublic
Actions

Authored by epriestley on Dec 27 2013, 6:45 PM.

Details

Reviewers

btrahan

Maniphest Tasks

Commits

Summary

Ref T4264. Instead of a dropdown, make this step more informative.

Test Plan

{F93928}

Lint

Lint Skipped

Unit

Unit Tests Skipped

btrahan added inline comments.

src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php
41	"Hook rules can block changes." sounds a little better to me

src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php
41	Oops, thanks.

Closed by commit rPf38a565aa5b6 (authored by @epriestley).

			Path	Packages
M			src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php (10 lines)
M			src/applications/diffusion/herald/HeraldPreCommitRefAdapter.php (10 lines)
M			src/applications/herald/adapter/HeraldAdapter.php (14 lines)
M			src/applications/herald/adapter/HeraldCommitAdapter.php (7 lines)
M			src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php (7 lines)
M			src/applications/herald/adapter/HeraldManiphestTaskAdapter.php (5 lines)
M			src/applications/herald/adapter/HeraldPholioMockAdapter.php (5 lines)
M			src/applications/herald/controller/HeraldNewController.php (46 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	17744	9bbaa33		Dec 27 2013, 6:45 PM	★	★
Diff 2	17746	9bbaa33	- Replace nonsense "Hooks rules" with grammatical "Hook rules".	Dec 27 2013, 9:15 PM	★	★
Diff 3	17755	79f57cf	Commit rPf38a565aa5b675e813a9955a7e41474cbf3bbef0	Dec 27 2013, 9:16 PM	★	★