Page MenuHomePhabricator
Differential D7846

Use radio buttons with explanatory text to select commit rule types
ClosedPublic
Actions

Authored by epriestley on Dec 27 2013, 6:45 PM.
Tags
None
Referenced Files
F15459320: D7846.id17755.diff
Mon, Mar 31, 11:53 AM
F15454568: D7846.id17744.diff
Sat, Mar 29, 7:07 PM
F15452670: D7846.id17746.diff
Sat, Mar 29, 6:36 AM
F15450713: D7846.diff
Fri, Mar 28, 5:16 PM
F15383938: D7846.id17746.diff
Fri, Mar 14, 6:22 PM
F15368449: D7846.diff
Wed, Mar 12, 2:14 AM
F15338552: D7846.id17755.diff
Sun, Mar 9, 11:24 AM
F15333176: D7846.id.diff
Sat, Mar 8, 12:29 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T4264: Implement Repo/Project Herald rules to provide a middle ground between personal and global rules
Commits
Restricted Diffusion Commit
rPf38a565aa5b6: Use radio buttons with explanatory text to select commit rule types
Summary

Ref T4264. Instead of a dropdown, make this step more informative.

Test Plan

{F93928}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan accepted this revision.Dec 27 2013, 9:08 PM
btrahan added inline comments.
src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php
41

"Hook rules can block changes." sounds a little better to me

epriestley added inline comments.Dec 27 2013, 9:14 PM
src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php
41

Oops, thanks.

epriestley updated this revision to Unknown Object (????).Dec 27 2013, 9:15 PM
  • Replace nonsense "Hooks rules" with grammatical "Hook rules".
epriestley closed this revision.Dec 27 2013, 9:16 PM

Closed by commit rPf38a565aa5b6 (authored by @epriestley).

Revision Contents
Changeset List

Diff 17755

View Options

src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php

Loading...
View Options

src/applications/diffusion/herald/HeraldPreCommitRefAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldCommitAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldManiphestTaskAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldPholioMockAdapter.php

Loading...
View Options

src/applications/herald/controller/HeraldNewController.php

Loading...
Phabricator · Built by Phacility