Page MenuHomePhabricator

Use radio buttons with explanatory text to select commit rule types
ClosedPublic

Authored by epriestley on Dec 27 2013, 6:45 PM.

Details

Summary

Ref T4264. Instead of a dropdown, make this step more informative.

Test Plan

{F93928}

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

btrahan accepted this revision.Dec 27 2013, 9:08 PM
btrahan added inline comments.
src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php
41

"Hook rules can block changes." sounds a little better to me

epriestley added inline comments.Dec 27 2013, 9:14 PM
src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php
41

Oops, thanks.

epriestley updated this revision to Unknown Object (????).Dec 27 2013, 9:15 PM
  • Replace nonsense "Hooks rules" with grammatical "Hook rules".
epriestley closed this revision.Dec 27 2013, 9:16 PM

Closed by commit rPf38a565aa5b6 (authored by @epriestley).