Page MenuHomePhabricator
Differential D7846

Use radio buttons with explanatory text to select commit rule types
ClosedPublic
Actions

Authored by epriestley on Dec 27 2013, 6:45 PM.
Tags
None
Referenced Files
F22740411: D7846.id17755.diff
Sun, Oct 4, 12:53 PM
F22740400: D7846.id17755.diff
Sun, Oct 4, 12:53 PM
F22663763: D7846.id17744.diff
Thu, Oct 1, 11:34 AM
F22546226: D7846.id.diff
Tue, Sep 22, 10:33 PM
Unknown Object (File)
Aug 16 2026, 1:25 AM
Unknown Object (File)
Aug 14 2026, 6:06 PM
Unknown Object (File)
Aug 14 2026, 9:28 AM
Unknown Object (File)
Aug 12 2026, 6:53 PM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T4264: Implement Repo/Project Herald rules to provide a middle ground between personal and global rules
Commits
Restricted Diffusion Commit
rPf38a565aa5b6: Use radio buttons with explanatory text to select commit rule types
Summary

Ref T4264. Instead of a dropdown, make this step more informative.

Test Plan

{F93928}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan accepted this revision.Dec 27 2013, 9:08 PM
btrahan added inline comments.
src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php
41

"Hook rules can block changes." sounds a little better to me

epriestley added inline comments.Dec 27 2013, 9:14 PM
src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php
41

Oops, thanks.

epriestley updated this revision to Unknown Object (????).Dec 27 2013, 9:15 PM
  • Replace nonsense "Hooks rules" with grammatical "Hook rules".
epriestley closed this revision.Dec 27 2013, 9:16 PM

Closed by commit rPf38a565aa5b6 (authored by @epriestley).

Revision Contents
Changeset List

Diff 17755

View Options

src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php

Loading...
View Options

src/applications/diffusion/herald/HeraldPreCommitRefAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldCommitAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldManiphestTaskAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldPholioMockAdapter.php

Loading...
View Options

src/applications/herald/controller/HeraldNewController.php

Loading...
Phabricator · Built by Phacility