Fix a commit hook issue with the initial commit to Mercurial repositories
ClosedPublic
Actions

Authored by epriestley on Dec 23 2013, 5:30 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T4257: Error on first push to empty Mercurial repository

Commits

Restricted Diffusion Commit
rP6daa2b6c2efa: Fix a commit hook issue with the initial commit to Mercurial repositories

Summary

Fixes T4257. The hg heads command exits with an error code and no output in an empty repository.

Just ignore the error code: we don't have a great way to distinguish between errors, and we ran another hg command moments before, so we have at least some confidence it isn't a PATH sort of thing.

Test Plan

Created a new Mercurial repository and pushed to hit the error in T4257. Applied this fix and got a clean push with an accurate push log.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Dec 23 2013, 6:25 PM

Closed by commit rP6daa2b6c2efa (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

engine/

DiffusionCommitHookEngine.php

11 lines

Diff 17693

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Fix a commit hook issue with the initial commit to Mercurial repositoriesClosedPublicActions