Add "Author" and "Committer" fields to Herald pre-commit content hooks
ClosedPublic
Actions

Authored by epriestley on Dec 19 2013, 5:06 PM.

Tags

None

Referenced Files

	F19921445: D7802.id.diff
	Mon, Apr 6, 5:21 AM

	F19919943: D7802.id.diff
	Sun, Apr 5, 9:40 AM

	F19919767: D7802.id.diff
	Sun, Apr 5, 5:59 AM

	F19919762: D7802.id.diff
	Sun, Apr 5, 5:59 AM

	F19919759: D7802.id.diff
	Sun, Apr 5, 5:59 AM

	F19899515: D7802.id17659.diff
	Sun, Mar 29, 9:16 PM

	F19899514: D7802.id17659.diff
	Sun, Mar 29, 9:16 PM

	F19899252: D7802.diff
	Sun, Mar 29, 6:41 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T4195: Implement pre-commit Herald rules

Commits

Restricted Diffusion Commit
rP134c8f554763: Add "Author" and "Committer" fields to Herald pre-commit content hooks

Summary

Ref T4195. Adds "Author" and "Committer" fields.

Test Plan

Created a rule using these fields:

{F90897}

...then pushed git, mercurial and svn commits and verified the correct values populated in the transcript:

{F90898}

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Dec 19 2013, 7:03 PM

Closed by commit rP134c8f554763 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

herald/

HeraldPreCommitContentAdapter.php

54 lines

Diff 17659

View Options

src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php

Add "Author" and "Committer" fields to Herald pre-commit content hooksClosedPublicActions