Page MenuHomePhabricator

Work around `hg` echoing warnings to stdout under --debug
ClosedPublic

Authored by epriestley on Dec 18 2013, 1:41 AM.
Tags
None
Referenced Files
F15391791: D7784.id.diff
Sat, Mar 15, 11:38 AM
F15326311: D7784.id17610.diff
Fri, Mar 7, 3:26 AM
Unknown Object (File)
Sun, Feb 23, 2:14 AM
Unknown Object (File)
Mon, Feb 17, 2:10 PM
Unknown Object (File)
Feb 12 2025, 2:35 AM
Unknown Object (File)
Feb 9 2025, 10:53 AM
Unknown Object (File)
Feb 9 2025, 10:53 AM
Unknown Object (File)
Feb 9 2025, 10:52 AM
Subscribers

Details

Summary

Ref T615. Ref T4237. With --debug, Mercurial will echo an "ignoring untrusted configuration option" warning to stdout if .hgrc has the wrong owner.

However, we need --debug to make {parents} usable, at least until the patches I got into the upstream are widely deployed. So after getting --debug output, strip off any leading warnings.

These warnings should always be in English, at least, since we set LANG explicitly.

Test Plan

Unit tests. @asherkin, maybe you can confirm this? I can't actually get the warning, but I think my hg in PATH is just a bit out of date.

Diff Detail

Branch
debug
Lint
No Lint Coverage
Unit
Tests Passed

Event Timeline

Afraid this didn't work, although I think it did cut out one case (I only see 2 phantom commits, rather than the previous 4, but the branches box is still erroring).

Failed to parse 'hg branches' output: ignoring untrusted configuration option hooks.pretxnchangegroup.phabricator = '/var/www/phabricator/phabricator/bin/commit-hook' 'GW' 'pretxnchangegroup'
epriestley updated this revision to Unknown Object (????).Dec 18 2013, 1:59 AM
  • Be more aggressive about stripping these messages, as they can appear anywhere in output.

That did the job, thanks.