Remove `-t -t` from Drydock SSH interface
ClosedPublic
Actions

Authored by hach-que on Dec 5 2013, 3:56 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jan 28, 12:19 PM

	Unknown Object (File)
	Tue, Jan 28, 7:46 AM

	Unknown Object (File)
	Tue, Jan 28, 12:43 AM

	Unknown Object (File)
	Tue, Jan 21, 7:20 PM

	Unknown Object (File)
	Tue, Jan 21, 9:08 AM

	Unknown Object (File)
	Fri, Jan 17, 8:33 PM

	Unknown Object (File)
	Thu, Jan 9, 12:03 AM

	Unknown Object (File)
	Sun, Jan 5, 8:32 PM

Subscribers

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T1049: Implement Harbormaster
T4111: Use Drydock to allocate build machines for Harbormaster

Commits

Restricted Diffusion Commit
rP48e80f05412e: Remove `-t -t` from Drydock SSH interface

Summary

These arguments prevent stderr from being routed correctly for Linux hosts and break Windows entirely. Removing them fixes the issue.

Test Plan

Removed those options and both Linux and Windows hosts had their output fed back into Harbormaster correctly.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley accepted this revision.Dec 5 2013, 3:56 AM

Closed by commit rP48e80f05412e (authored by @hach-que).

Revision Contents
Changeset List

Path

Size

src/

applications/

drydock/

interface/

command/

DrydockSSHCommandInterface.php

4 lines

Diff 17414

View Options

src/applications/drydock/interface/command/DrydockSSHCommandInterface.php

Remove `-t -t` from Drydock SSH interfaceClosedPublicActions