Respect "can edit username" in registration UI
ClosedPublic
Actions

Authored by epriestley on Nov 13 2013, 6:26 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Sep 12, 9:59 PM

	Unknown Object (File)
	Thu, Sep 12, 9:58 PM

	Unknown Object (File)
	Thu, Sep 12, 9:58 PM

	Unknown Object (File)
	Thu, Sep 12, 9:58 PM

	Unknown Object (File)
	Tue, Sep 3, 6:18 PM

	Unknown Object (File)
	Tue, Sep 3, 11:59 AM

	Unknown Object (File)
	Sun, Aug 25, 6:03 PM

	Unknown Object (File)
	Sat, Aug 24, 4:08 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan
datr

Maniphest Tasks

Restricted Maniphest Task

Commits

Restricted Diffusion Commit
rPfb6e38548b0c: Respect "can edit username" in registration UI

Summary

Fixes T3741. The flag is respected in terms of actually creating the account, but the UI is a bit unclear.

This can never occur naturally, but installs can register an event which locks it.

Test Plan

Artificially locked it, verified I got more reasonable UI;

{F81282}

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Pretty much matches what I've done to my patched copy. Looks good.

Thanks! Sorry this took so long to get to, I thought it was a little more involved than it actually was.

Closed by commit rPfb6e38548b0c (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

controller/

PhabricatorAuthRegisterController.php

11 lines

Diff 17108

View Options

src/applications/auth/controller/PhabricatorAuthRegisterController.php

Respect "can edit username" in registration UIClosedPublicActions