Page MenuHomePhabricator

Add a "Make an HTTP Request" build step
ClosedPublic

Authored by epriestley on Nov 9 2013, 3:27 AM.
Tags
None
Referenced Files
F19233167: D7541.diff
Sun, Dec 21, 5:35 PM
F19086754: D7541.id.diff
Dec 2 2025, 10:37 PM
F19083920: D7541.diff
Dec 2 2025, 1:59 PM
F19079450: D7541.diff
Dec 1 2025, 9:03 PM
F19051251: D7541.id17029.diff
Nov 28 2025, 12:12 AM
F19039278: D7541.diff
Nov 26 2025, 7:08 AM
F19025715: D7541.diff
Nov 24 2025, 8:45 AM
F18858343: D7541.id.diff
Nov 1 2025, 9:53 PM
Subscribers

Details

Summary

Ref T1049. This is very minimal, but does what it says.

I merged the variable replacement code so Remote + HTTP can share more stuff.

Test Plan

Ran "HTTP" and "Remote" build plans.

{F79886}

{F79887}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/harbormaster/controller/HarbormasterBuildCancelController.php
29

This is because MySQL complains about setting BOOLEAN columns to '' when it's in strict mode. We should probably do a better job of abstracting this, but for now just use 1 and 0 explicitly.

Tested this against both http://www.google.com/ and http://code.redpointsoftware.com.au/. Google throws a lovely 405 Method Not Allowed and thus the build fails. My Phabricator instance returns 200 OK and the build passes.