Page MenuHomePhabricator

Add a "Make an HTTP Request" build step
ClosedPublic

Authored by epriestley on Nov 9 2013, 3:27 AM.
Tags
None
Referenced Files
F15454089: D7541.diff
Sat, Mar 29, 4:15 PM
F15448674: D7541.id17029.diff
Fri, Mar 28, 6:13 AM
F15447603: D7541.id.diff
Fri, Mar 28, 12:41 AM
F15442351: D7541.diff
Wed, Mar 26, 10:55 PM
F15419104: D7541.diff
Fri, Mar 21, 3:30 AM
F15391052: D7541.diff
Sat, Mar 15, 7:59 AM
F15387670: D7541.id17029.diff
Sat, Mar 15, 2:45 AM
Unknown Object (File)
Feb 22 2025, 5:57 PM
Subscribers

Details

Summary

Ref T1049. This is very minimal, but does what it says.

I merged the variable replacement code so Remote + HTTP can share more stuff.

Test Plan

Ran "HTTP" and "Remote" build plans.

{F79886}

{F79887}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/harbormaster/controller/HarbormasterBuildCancelController.php
29

This is because MySQL complains about setting BOOLEAN columns to '' when it's in strict mode. We should probably do a better job of abstracting this, but for now just use 1 and 0 explicitly.

Tested this against both http://www.google.com/ and http://code.redpointsoftware.com.au/. Google throws a lovely 405 Method Not Allowed and thus the build fails. My Phabricator instance returns 200 OK and the build passes.