Page MenuHomePhabricator

Add a "Make an HTTP Request" build step
ClosedPublic

Authored by epriestley on Nov 9 2013, 3:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 10:06 PM
Unknown Object (File)
Fri, Apr 19, 3:28 AM
Unknown Object (File)
Fri, Apr 19, 3:28 AM
Unknown Object (File)
Fri, Apr 19, 3:28 AM
Unknown Object (File)
Fri, Apr 12, 12:16 AM
Unknown Object (File)
Thu, Apr 11, 7:41 AM
Unknown Object (File)
Thu, Apr 11, 4:39 AM
Unknown Object (File)
Tue, Apr 2, 1:13 AM
Subscribers

Details

Summary

Ref T1049. This is very minimal, but does what it says.

I merged the variable replacement code so Remote + HTTP can share more stuff.

Test Plan

Ran "HTTP" and "Remote" build plans.

{F79886}

{F79887}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/harbormaster/controller/HarbormasterBuildCancelController.php
29

This is because MySQL complains about setting BOOLEAN columns to '' when it's in strict mode. We should probably do a better job of abstracting this, but for now just use 1 and 0 explicitly.

Tested this against both http://www.google.com/ and http://code.redpointsoftware.com.au/. Google throws a lovely 405 Method Not Allowed and thus the build fails. My Phabricator instance returns 200 OK and the build passes.