Page MenuHomePhabricator
Differential D7493

Add header icons to PHUIPropertyListView
ClosedPublic
Actions

Authored by chad on Nov 4 2013, 6:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 26, 6:35 AM
Unknown Object (File)
Wed, Feb 26, 6:34 AM
Unknown Object (File)
Wed, Feb 26, 6:34 AM
Unknown Object (File)
Wed, Feb 26, 6:34 AM
Unknown Object (File)
Mon, Feb 24, 3:00 AM
Unknown Object (File)
Mon, Feb 17, 2:55 AM
Unknown Object (File)
Mon, Feb 17, 1:45 AM
Unknown Object (File)
Wed, Feb 5, 7:56 PM
View All Files
Subscribers
aran
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP1c31ea3a6075: Add header icons to PHUIPropertyListView
Summary

Adds summary (description) and test plan icons to make these area's more unique and differentiated over general sections.

Test Plan

Test a diff, a commit, a task

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

chad added a comment.Nov 4 2013, 6:59 PM

{F78396}

epriestley accepted this revision.Nov 4 2013, 7:13 PM

I love icons

These look great.

chad closed this revision.Nov 4 2013, 7:14 PM

Closed by commit rP1c31ea3a6075 (authored by @chad).

Revision Contents
Changeset List

PathSize
resources/
sprite/
manifest/
10 lines
status_1x/
status_2x/
src/
102 lines
applications/
differential/
view/
8 lines
diffusion/
controller/
4 lines
maniphest/
controller/
4 lines
view/
phui/
21 lines
webroot/
rsrc/
css/
phui/
5 lines
86 lines
image/

Diff 16885

View Options

resources/sprite/manifest/status.json

Loading...
View Options

resources/sprite/status_1x/pl-summary.png

Loading...
View Options

resources/sprite/status_1x/pl-testplan.png

Loading...
View Options

resources/sprite/status_2x/pl-summary.png

Loading...
View Options

resources/sprite/status_2x/pl-testplan.png

Loading...
View Options

src/__celerity_resource_map__.php

Loading...
View Options

src/applications/differential/view/DifferentialRevisionDetailView.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
View Options

src/view/phui/PHUIPropertyListView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-property-list-view.css

Loading...
View Options

webroot/rsrc/css/sprite-status.css

Loading...
View Options

webroot/rsrc/image/sprite-status-X2.png

Loading...
View Options

webroot/rsrc/image/sprite-status.png

Loading...
Phabricator · Built by Phacility