Page MenuHomePhabricator

Add support for branch-related configuration to new Repository edit workflow
ClosedPublic

Authored by epriestley on Oct 25 2013, 5:27 PM.
Tags
None
Referenced Files
F13391120: D7399.id16682.diff
Tue, Jul 2, 8:16 AM
F13391087: D7399.id16668.diff
Tue, Jul 2, 8:08 AM
F13391086: D7399.id.diff
Tue, Jul 2, 8:08 AM
F13391058: D7399.diff
Tue, Jul 2, 7:56 AM
F13378741: D7399.diff
Sat, Jun 29, 5:14 AM
F13360721: D7399.diff
Tue, Jun 25, 12:00 PM
F13321458: D7399.diff
Fri, Jun 14, 6:53 AM
F13297352: D7399.id16668.diff
Fri, Jun 7, 4:07 AM
Subscribers

Details

Reviewers
btrahan
chad
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPdcb0b1b64f73: Add support for branch-related configuration to new Repository edit workflow
Summary

Ref T2231. Modernizes editing "Default Branch", "Track Only", and "Autoclose Only".

Test Plan

See screenshots.

Diff Detail

Branch
dbranches
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

{F74984}

{F74985}

{F74986}

{F74987}

A whatevs inline - I think its cleaner as I suggest but the odds of needing the variables as you have them seems high so yeah.

src/applications/diffusion/controller/DiffusionRepositoryEditController.php
11–26

you could just instantiate $has_branches with this switch statement

Yeah I'm assuming I'm going to end up with a couple more of those in a bit, but maybe not. I do use $is_svn in the next diff I think, not sure how busy it will be by the time I'm done.