Paths

Table of Contentst

Fix chatlog application query integration
ClosedPublic
Actions

Authored by epriestley on Oct 22 2013, 6:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 19, 8:34 AM

	Unknown Object (File)
	Sat, Dec 14, 6:20 PM

	Unknown Object (File)
	Sun, Dec 8, 12:37 PM

	Unknown Object (File)
	Mon, Nov 25, 6:51 PM

	Unknown Object (File)
	Nov 19 2024, 11:29 PM

	Unknown Object (File)
	Nov 16 2024, 4:23 AM

	Unknown Object (File)
	Nov 13 2024, 1:31 AM

	Unknown Object (File)
	Nov 10 2024, 7:00 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP7dd31a16d973: Fix chatlog application query integration

Summary

class_exists() is case-insensitive, but PhabricatorApplication::getByClass() is not.

Test Plan

Fixed unit test to fail, then fixed code to pass unit test.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Oct 22 2013, 8:39 PM

Closed by commit rP7dd31a16d973 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

chatlog/

PhabricatorChatLogChannelQuery.php

2 lines

PhabricatorChatLogQuery.php

2 lines

policy/

__tests__/

PhabricatorPolicyTestCase.php

2 lines

Diff 16621

View Options

src/applications/chatlog/PhabricatorChatLogChannelQuery.php

View Options

src/applications/chatlog/PhabricatorChatLogQuery.php

View Options

src/applications/policy/tests/PhabricatorPolicyTestCase.php

Fix chatlog application query integrationClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 16621

src/applications/chatlog/PhabricatorChatLogChannelQuery.php

src/applications/chatlog/PhabricatorChatLogQuery.php

src/applications/policy/__tests__/PhabricatorPolicyTestCase.php

Fix chatlog application query integration
ClosedPublic
Actions

Revision Contents
Changeset List

src/applications/policy/tests/PhabricatorPolicyTestCase.php