Paths

Table of Contentst

Fix chatlog application query integration
ClosedPublic
Actions

Authored by epriestley on Oct 22 2013, 6:41 PM.

Tags

None

Referenced Files

	F15508930: D7379.diff
	Wed, Apr 16, 7:30 AM

	F15485170: D7379.id16618.diff
	Wed, Apr 9, 10:18 PM

	F15478390: D7379.id16621.diff
	Mon, Apr 7, 10:41 PM

	F15467540: D7379.id16618.diff
	Thu, Apr 3, 4:00 PM

	F15467217: D7379.id.diff
	Thu, Apr 3, 1:47 PM

	F15464214: D7379.diff
	Wed, Apr 2, 7:24 AM

	F15459315: D7379.id.diff
	Mon, Mar 31, 11:51 AM

	F15431452: D7379.id.diff
	Mon, Mar 24, 12:25 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP7dd31a16d973: Fix chatlog application query integration

Summary

class_exists() is case-insensitive, but PhabricatorApplication::getByClass() is not.

Test Plan

Fixed unit test to fail, then fixed code to pass unit test.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Oct 22 2013, 8:39 PM

Closed by commit rP7dd31a16d973 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

chatlog/

PhabricatorChatLogChannelQuery.php

2 lines

PhabricatorChatLogQuery.php

2 lines

policy/

__tests__/

PhabricatorPolicyTestCase.php

2 lines

Diff 16621

View Options

src/applications/chatlog/PhabricatorChatLogChannelQuery.php

View Options

src/applications/chatlog/PhabricatorChatLogQuery.php

View Options

src/applications/policy/tests/PhabricatorPolicyTestCase.php

Fix chatlog application query integrationClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 16621

src/applications/chatlog/PhabricatorChatLogChannelQuery.php

src/applications/chatlog/PhabricatorChatLogQuery.php

src/applications/policy/__tests__/PhabricatorPolicyTestCase.php

Fix chatlog application query integration
ClosedPublic
Actions

Revision Contents
Changeset List

src/applications/policy/tests/PhabricatorPolicyTestCase.php