Fixes T3675.
- Maniphest had a couple of old non-event listeners; move them to events.
- Make most of the similar listeners a little more similar.
- Add checks for access to the application.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- Restricted Maniphest Task
- Commits
- Restricted Diffusion Commit
rP8994a81b3538: Make event-triggered actions more aware of application access
- Viewed profile, project, task, revision.
- Clicked all the actions.
- Blocked access to various applications and verified the actions vanished.
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| src/applications/phriction/event/PhrictionActionMenuEventListener.php | ||
|---|---|---|
| 18–20 | maybs this should be upgraded to some getObject? It seems like that is standard-ish and then we get type checking which will give us other guarantees about object. Just maybs for someday thought | |
| src/applications/phriction/event/PhrictionActionMenuEventListener.php | ||
|---|---|---|
| 18–20 | Yeah, we could probably take a pass on PhabricatorEvent at some point and unify some of it. I'd guess getObject() is probably reasonable at a minimum. | |