Page MenuHomePhabricator
Differential D7336

Add Link button to Remarkup assist
ClosedPublic
Actions

Authored by vrana on Oct 17 2013, 2:09 AM.
Tags
None
Referenced Files
F15476607: D7336.id16545.diff
Mon, Apr 7, 7:50 AM
F15465778: D7336.id16544.diff
Wed, Apr 2, 11:03 PM
F15456457: D7336.id16519.diff
Sun, Mar 30, 9:52 AM
F15454942: D7336.id16545.diff
Sat, Mar 29, 9:22 PM
F15450333: D7336.id.diff
Fri, Mar 28, 3:04 PM
F15449942: D7336.id16543.diff
Fri, Mar 28, 1:04 PM
F15446785: D7336.diff
Thu, Mar 27, 8:14 PM
F15433840: D7336.id16545.diff
Tue, Mar 25, 12:48 AM
View All Files
Subscribers
aran
chad
epriestley

Details

Reviewers
epriestley
chad
Commits
Restricted Diffusion Commit
rP82e57ab8a76d: Add Link button to Remarkup assist
Summary

Believe it or not, I forgot how to create a link in Remarkup.

Test Plan

Clicked on it with selected URL, selected text and without a selection.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

vrana planned changes to this revision.Oct 17 2013, 2:10 AM
vrana added a subscriber: chad.

@chad, can you please sketch up some icon for it?

vrana updated this revision to Unknown Object (????).Oct 18 2013, 1:41 AM

Name the class, move the icon

vrana updated this revision to Unknown Object (????).Oct 18 2013, 1:45 AM

Phtize

vrana added reviewers: chad, epriestley.Oct 18 2013, 1:46 AM
epriestley accepted this revision.Oct 18 2013, 1:48 AM
vrana closed this revision.Oct 18 2013, 1:59 AM

Closed by commit rP82e57ab8a76d (authored by @vrana).

chad added a comment.Oct 18 2013, 2:39 AM

In general the remarkup bar is:

Fonts | Formatting | Helpers/Misc

vrana added a comment.Oct 18 2013, 3:44 PM

It seemed to me more like:

Inline | Block | Tools

Feel free to move the button but this seems like a good position to me.

Revision Contents
Changeset List

PathSize
resources/
sprite/
manifest/
2 lines
src/
176 lines
infrastructure/
javelin/
2 lines
view/
form/
control/
3 lines
webroot/
rsrc/
css/
2 lines
js/
core/
8 lines

Diff 16545

View Options

resources/sprite/manifest/icons.json

Loading...
View Options

src/__celerity_resource_map__.php

Loading...
View Options

src/infrastructure/javelin/Javelin.php

Loading...
View Options

src/view/form/control/PhabricatorRemarkupControl.php

Loading...
View Options

webroot/rsrc/css/sprite-icons.css

Loading...
View Options

webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js

Loading...
Phabricator · Built by Phacility