Page MenuHomePhabricator

Add an icon+background selector for project images
ClosedPublic

Authored by epriestley on Oct 16 2013, 10:58 PM.
Tags
None
Referenced Files
F14077523: D7333.diff
Fri, Nov 22, 12:02 AM
Unknown Object (File)
Sun, Nov 17, 6:41 PM
Unknown Object (File)
Thu, Nov 14, 4:57 PM
Unknown Object (File)
Sun, Nov 10, 2:00 AM
Unknown Object (File)
Tue, Nov 5, 6:46 PM
Unknown Object (File)
Sat, Nov 2, 3:04 AM
Unknown Object (File)
Thu, Oct 24, 4:21 PM
Unknown Object (File)
Oct 17 2024, 11:13 PM
Subscribers

Details

Summary

Makes it easy to choose distinctive icons for projects.

Test Plan

{F71018}

{F71020}

{F71019}

{F71021}

Diff Detail

Branch
pimage
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

src/applications/files/controller/PhabricatorFileComposeController.php
74

This took roughly 90% of the time.

src/applications/files/controller/PhabricatorFileComposeController.php
74

and 100% of your happiness.

src/applications/files/controller/PhabricatorFileComposeController.php
230

I assumed we just would do this in CSS, or was that not possible?

Although it's possible, I think it would be really complicated to sometimes have profile images be profile images and sometimes have them be runtime HTML composites. I don't see any major advantage to doing it in HTML/CSS -- is there anything I'm missing? The only thing that springs to mind is the 2X stuff, but we could composite these images at 2x just as easily (it's just moot right now since we scale profile images down to 50x50 regardless).

(If we eventually retool profile images so they can be covered with hats and wear badges and have special borders, moving to HTML representations might make sense.)

Ah I see. I think these turned out nicely. :)

Yeah -- the workflow I ended up with feels a little weird bit to me and might merit some tweaking at some point, but I think the results look great.

i am entranced by doge today.

Hmm, what do you think about use the light versions of the colors? They seem a little more background-y.

I had both in an initial version, although at first glance they seemed a little weird and too desaturated. I had them laid out like red, lightred, blue, lightblue though. Maybe laying them out like red, blue ... lightred, lightblue ... will be more pleasing.

It might also be nice to have a {$black} or {$dark} color (and then {$lightdark}, of course).

You can do little ones too.

{F71925}

The light colors are really light -- it's hard for me to pick out the icons against them. What do you think?

{F71927}

We could compose the icons differently (although I'm not sure I can, like, dropshadow in PHP very reasonably without some effort), or stroke the sources / offer dark sources, or use mid flavors of the colors...

no you are right those are terrible. we should then just add the dark like the example and maybe our standard photo background color #c4cde0

epriestley updated this revision to Unknown Object (????).Oct 17 2013, 4:23 PM

Those look good to me.

  • Add dark/example color.
  • Add standard/default background color.

I'm also completely faking the "selected" state for the button. I don't think we have any uses for it elsewhere, but I'm happy to clean this up if we have some reason to build a real state eventually.