Page MenuHomePhabricator

Render public content as "Public" in headers, not "Public (No Login Required)"
ClosedPublic

Authored by epriestley on Oct 14 2013, 8:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 5, 4:32 AM
Unknown Object (File)
Feb 25 2024, 1:01 AM
Unknown Object (File)
Feb 25 2024, 12:59 AM
Unknown Object (File)
Jan 27 2024, 6:23 AM
Unknown Object (File)
Jan 13 2024, 2:56 AM
Unknown Object (File)
Dec 21 2023, 7:22 PM
Unknown Object (File)
Dec 20 2023, 11:16 AM
Unknown Object (File)
Dec 7 2023, 7:18 AM
Subscribers

Details

Summary

Ref T603. Although I think the parenthetical is valuable when setting policies to make sure no one accidentally opens content up, it's super annoying in headers.

This makes headers say "Public". Everything else still says "Public (No Login Required)".

Test Plan

{F69469}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

I often wonder if 'All Users' is clear enough, as I sometimes feel that means Public. 'Registered Users' or 'Logged In Users' or something similar? I don't feel strongly here, just tossing it out there.