Improve remarkup metadata robustness against debris in the database
ClosedPublic
Actions

Authored by epriestley on May 28 2022, 1:29 PM.

Details

Reviewers: None
Maniphest Tasks: T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits: rP95481b5e3c49: (stable) Improve remarkup metadata robustness against debris in the database
rP835cd7f2706f: Improve remarkup metadata robustness against debris in the database

Summary

Ref T13682. Versioned drafts may have missing or unexpected metadata:

versioned drafts from an older version of Phabricator may be missing metadata;
versioned drafts created by an older UI against a newer version of Phabricator may have null metadata.

Generally, make these workflows robust to metadata in unexpected formats, so database debris doesn't break the UI.

Test Plan

Simulated debris, interacted with UI.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley requested review of this revision.May 28 2022, 1:29 PM

epriestley created this revision.

Harbormaster completed remote builds in B25757: Diff 52074.May 28 2022, 1:29 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 28 2022, 1:29 PM

Closed by commit rP835cd7f2706f: Improve remarkup metadata robustness against debris in the database (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP835cd7f2706f: Improve remarkup metadata robustness against debris in the database.

epriestley added a commit: rP95481b5e3c49: (stable) Improve remarkup metadata robustness against debris in the database.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

storage/

PhabricatorApplicationTransaction.php

7 lines

view/

PhabricatorApplicationTransactionCommentView.php

4 lines

Diff 52075

View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php