Page MenuHomePhabricator
Differential D21845

Move Slowvote vote types to a separate object
ClosedPublic
Actions

Authored by epriestley on May 26 2022, 5:09 PM.
Tags
None
Referenced Files
F18852545: D21845.diff
Fri, Oct 31, 9:57 AM
F18850802: D21845.diff
Thu, Oct 30, 7:31 PM
F18815370: D21845.id.diff
Tue, Oct 21, 1:54 AM
F18809127: D21845.diff
Sun, Oct 19, 11:24 AM
F18763505: D21845.id52066.diff
Tue, Oct 7, 12:31 AM
F18763496: D21845.id.diff
Tue, Oct 7, 12:29 AM
F18762798: D21845.id52064.diff
Mon, Oct 6, 8:41 PM
F18755581: D21845.id52065.diff
Sun, Oct 5, 6:22 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits
rP9dad49472c04: Move Slowvote vote types to a separate object
Summary

Ref T13682. Extract Slowvote vote types to a separate object, to prepare for turning them into API-friendly string constants.

Test Plan

Created, edited, and voted in Slowvote polls. Grepped for affected constants.

Diff Detail

Repository
rP Phabricator
Branch
slowvote5
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/applications/slowvote/controller/PhabricatorSlowvoteEditController.php:198PHL1Unknown Symbol
Errorsrc/applications/slowvote/xaction/PhabricatorSlowvoteMethodTransaction.php:3XHP19Class-Filename Mismatch
Unit
Tests Passed
Build Status
Buildable 25752
Build 35580: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.May 26 2022, 5:09 PM
epriestley created this revision.
Harbormaster completed remote builds in B25752: Diff 52064.May 26 2022, 5:09 PM
epriestley updated this revision to Diff 52065.May 26 2022, 5:09 PM
  • Update some file/class names.
Harbormaster completed remote builds in B25753: Diff 52065.May 26 2022, 5:09 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 26 2022, 5:17 PM
Closed by commit rP9dad49472c04: Move Slowvote vote types to a separate object (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP9dad49472c04: Move Slowvote vote types to a separate object.

Revision Contents
Changeset List

Diff 52064

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/slowvote/constants/SlowvotePollVotingMethod.php

Loading...
View Options

src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php

Loading...
View Options

src/applications/slowvote/controller/PhabricatorSlowvoteVoteController.php

Loading...
View Options

src/applications/slowvote/storage/PhabricatorSlowvotePoll.php

Loading...
View Options

src/applications/slowvote/view/SlowvoteEmbedView.php

Loading...
View Options

src/applications/slowvote/xaction/PhabricatorSlowvoteMethodTransaction.php

Loading...
Phabricator · Built by Phacility