Page MenuHomePhabricator

Remove product literal strings in "pht()", part 18
ClosedPublic

Authored by epriestley on Apr 25 2022, 11:05 PM.
Tags
None
Referenced Files
F19742188: D21784.id51940.diff
Sun, Feb 15, 11:37 AM
F19647368: D21784.diff
Fri, Feb 6, 3:39 AM
F19636417: D21784.id.diff
Thu, Feb 5, 1:04 PM
F19622524: D21784.id51940.diff
Wed, Feb 4, 2:12 PM
F19530085: D21784.id51940.diff
Mon, Jan 19, 8:36 PM
F19526853: D21784.id51940.diff
Sun, Jan 18, 8:37 PM
F19509048: D21784.id.diff
Jan 10 2026, 2:17 PM
F19505119: D21784.diff
Jan 9 2026, 9:17 AM
Subscribers
None

Details

Summary

Ref T13658.

Test Plan

Static checks only.

Diff Detail

Repository
rP Phabricator
Branch
product19
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/applications/diviner/controller/DivinerMainController.php:51XHP134Use of Product Name Literal
Unit
Tests Passed
Build Status
Buildable 25677
Build 35505: arc lint + arc unit

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 11:47 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.