Page MenuHomePhabricator

Remove product literal strings in "pht()", part 18
ClosedPublic

Authored by epriestley on Apr 25 2022, 11:05 PM.
Tags
None
Referenced Files
F19530085: D21784.id51940.diff
Mon, Jan 19, 8:36 PM
F19526853: D21784.id51940.diff
Sun, Jan 18, 8:37 PM
F19509048: D21784.id.diff
Sat, Jan 10, 2:17 PM
F19505119: D21784.diff
Fri, Jan 9, 9:17 AM
F19505055: D21784.diff
Fri, Jan 9, 8:49 AM
F19504383: D21784.id51921.diff
Fri, Jan 9, 5:05 AM
F19304404: D21784.id51940.diff
Dec 24 2025, 10:44 AM
F19243123: D21784.diff
Dec 21 2025, 11:49 PM
Subscribers
None

Details

Summary

Ref T13658.

Test Plan

Static checks only.

Diff Detail

Repository
rP Phabricator
Branch
product19
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/applications/diviner/controller/DivinerMainController.php:51XHP134Use of Product Name Literal
Unit
Tests Passed
Build Status
Buildable 25677
Build 35505: arc lint + arc unit

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 11:47 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.