Page MenuHomePhabricator

Remove product literal strings in "pht()", part 18
ClosedPublic

Authored by epriestley on Apr 25 2022, 11:05 PM.
Tags
None
Referenced Files
F13223892: D21784.diff
Sun, May 19, 5:13 AM
F13222346: D21784.diff
Sun, May 19, 3:31 AM
F13206007: D21784.id51921.diff
Wed, May 15, 4:29 AM
F13205964: D21784.id.diff
Wed, May 15, 4:06 AM
F13204951: D21784.diff
Wed, May 15, 1:17 AM
F13198257: D21784.diff
Mon, May 13, 5:27 AM
F13188199: D21784.diff
Sat, May 11, 5:05 AM
F13183544: D21784.diff
Fri, May 10, 10:16 AM
Subscribers
None

Details

Summary

Ref T13658.

Test Plan

Static checks only.

Diff Detail

Repository
rP Phabricator
Branch
product19
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/applications/diviner/controller/DivinerMainController.php:51XHP134Use of Product Name Literal
Unit
Tests Passed
Build Status
Buildable 25677
Build 35505: arc lint + arc unit

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 11:47 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.