Page MenuHomePhabricator

Remove product literal strings in "pht()", part 18
ClosedPublic

Authored by epriestley on Apr 25 2022, 11:05 PM.
Tags
None
Referenced Files
F10883916: D21784.id51940.diff
Fri, Jul 1, 8:06 AM
F10883915: D21784.id51921.diff
Fri, Jul 1, 8:06 AM
F10883912: D21784.id.diff
Fri, Jul 1, 8:05 AM
Unknown Object (File)
Wed, Jun 29, 9:28 AM
Unknown Object (File)
Tue, Jun 28, 6:29 PM
Unknown Object (File)
Thu, Jun 16, 10:13 AM
Unknown Object (File)
Thu, Jun 16, 10:13 AM
Unknown Object (File)
Thu, Jun 16, 10:13 AM
Subscribers
None

Details

Summary

Ref T13658.

Test Plan

Static checks only.

Diff Detail

Repository
rP Phabricator
Branch
product19
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/applications/diviner/controller/DivinerMainController.php:51XHP134Use of Product Name Literal
Unit
Tests Passed
Build Status
Buildable 25677
Build 35505: arc lint + arc unit

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 11:47 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.