Page MenuHomePhabricator

Improve some PHP 8.1 behavior in "bin/auth recover"
ClosedPublic

Authored by epriestley on Apr 19 2022, 9:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jul 1, 7:38 AM
Unknown Object (File)
Fri, Jul 1, 7:38 AM
Unknown Object (File)
Fri, Jul 1, 7:38 AM
Unknown Object (File)
Fri, Jul 1, 7:37 AM
Unknown Object (File)
Wed, Jun 29, 9:10 AM
Unknown Object (File)
Tue, Jun 21, 5:57 AM
Unknown Object (File)
Sun, Jun 19, 9:44 AM
Unknown Object (File)
Thu, Jun 16, 10:06 AM
Subscribers
None

Details

Summary

Ref T13588. Fix a couple of argument parsing issues here.

Test Plan

Ran "bin/auth recover" under PHP 8.1.

Diff Detail

Repository
rP Phabricator
Branch
php1
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 25641
Build 35469: arc lint + arc unit

Unit TestsFailed

TimeTest
14 msPhabricatorAuthSSHKeyTestCase::testRevokeSSHKey
EXCEPTION (RuntimeException): strlen(): Passing null to parameter #1 ($string) of type string is deprecated #0 /Users/epriestley/dev/core/lib/phabricator/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php(2923): PhutilErrorHandler::handleError(8192, 'strlen(): Passi...', '/Users/epriestl...', 2923) #1 /Users/epriestley/dev/core/lib/phabricator/src/applications/auth/editor/PhabricatorAuthSSHKeyEditor.php(112): PhabricatorApplicationTransactionEditor->validateIsEmptyTextField(NULL, Array)
383 msPhabricatorAuthPasswordTestCase::testCompare
2 assertions passed.
35 msPhabricatorAuthPasswordTestCase::testPasswordBlocklisting
15 assertions passed.
1,634 msPhabricatorAuthPasswordTestCase::testPasswordEngine
20 assertions passed.
320 msPhabricatorAuthPasswordTestCase::testPasswordUpgrade
9 assertions passed.
View Full Test Results (1 Failed · 11 Passed)