Page MenuHomePhabricator

Improve some PHP 8.1 behavior in "bin/auth recover"
ClosedPublic

Authored by epriestley on Apr 19 2022, 9:48 PM.
Tags
None
Referenced Files
F13036248: D21757.id51866.diff
Sun, Apr 14, 5:10 PM
Unknown Object (File)
Thu, Apr 11, 10:56 AM
Unknown Object (File)
Wed, Apr 10, 2:07 AM
Unknown Object (File)
Sat, Apr 6, 4:13 AM
Unknown Object (File)
Sat, Mar 30, 10:21 AM
Unknown Object (File)
Fri, Mar 29, 3:31 PM
Unknown Object (File)
Thu, Mar 28, 7:33 PM
Unknown Object (File)
Thu, Mar 28, 7:12 PM
Subscribers
None

Details

Summary

Ref T13588. Fix a couple of argument parsing issues here.

Test Plan

Ran "bin/auth recover" under PHP 8.1.

Diff Detail

Repository
rP Phabricator
Branch
php1
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 25641
Build 35469: arc lint + arc unit

Unit TestsFailed

TimeTest
14 msPhabricatorAuthSSHKeyTestCase::testRevokeSSHKey
EXCEPTION (RuntimeException): strlen(): Passing null to parameter #1 ($string) of type string is deprecated #0 /Users/epriestley/dev/core/lib/phabricator/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php(2923): PhutilErrorHandler::handleError(8192, 'strlen(): Passi...', '/Users/epriestl...', 2923) #1 /Users/epriestley/dev/core/lib/phabricator/src/applications/auth/editor/PhabricatorAuthSSHKeyEditor.php(112): PhabricatorApplicationTransactionEditor->validateIsEmptyTextField(NULL, Array)
383 msPhabricatorAuthPasswordTestCase::testCompare
2 assertions passed.
35 msPhabricatorAuthPasswordTestCase::testPasswordBlocklisting
15 assertions passed.
1,634 msPhabricatorAuthPasswordTestCase::testPasswordEngine
20 assertions passed.
320 msPhabricatorAuthPasswordTestCase::testPasswordUpgrade
9 assertions passed.
View Full Test Results (1 Failed · 11 Passed)