Ref T13588. Fix a couple of argument parsing issues here.
Details
Details
- Reviewers
- None
- Maniphest Tasks
- T13588: PHP 8 Compatibility
- Commits
- rP21b1a304b60a: Improve some PHP 8.1 behavior in "bin/auth recover"
Ran "bin/auth recover" under PHP 8.1.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- php1
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 25641 Build 35469: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 14 ms | PhabricatorAuthSSHKeyTestCase::testRevokeSSHKey EXCEPTION (RuntimeException): strlen(): Passing null to parameter #1 ($string) of type string is deprecated
#0 /Users/epriestley/dev/core/lib/phabricator/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php(2923): PhutilErrorHandler::handleError(8192, 'strlen(): Passi...', '/Users/epriestl...', 2923)
#1 /Users/epriestley/dev/core/lib/phabricator/src/applications/auth/editor/PhabricatorAuthSSHKeyEditor.php(112): PhabricatorApplicationTransactionEditor->validateIsEmptyTextField(NULL, Array)
| |
| 383 ms | PhabricatorAuthPasswordTestCase::testCompare 2 assertions passed. | |
| 35 ms | PhabricatorAuthPasswordTestCase::testPasswordBlocklisting 15 assertions passed. | |
| 1,634 ms | PhabricatorAuthPasswordTestCase::testPasswordEngine 20 assertions passed. | |
| 320 ms | PhabricatorAuthPasswordTestCase::testPasswordUpgrade 9 assertions passed. | |
| View Full Test Results (1 Failed · 11 Passed) |