Page MenuHomePhabricator

Hide event start times on subsequent days
Needs ReviewPublic

Authored by 0 on Sun, Oct 3, 9:40 PM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

The start time of a multi-day event is currently displayed on all days, which is misleading. Hide it when showing any day other than the first. Also change the icons to point to the past, making it clear which of the displayed events are continuations of multi-day events.

Test Plan

Looked at events (single- and multi-day, timed and all-day) from several vantage points (before, after):

  • Month View query
    month_before.png (307×1 px, 33 KB)
    month_after.png (307×1 px, 30 KB)
  • Day View query
    day1_before.png (605×460 px, 25 KB)
    day1_after.png (605×460 px, 22 KB)
    day2_before.png (604×460 px, 25 KB)
    day2_after.png (604×460 px, 21 KB)
  • user profile
    week_before.png (324×300 px, 8 KB)
    week_after.png (324×300 px, 7 KB)

Diff Detail

Repository
rP Phabricator
Branch
multiday
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25574
Build 35376: Run Core Tests
Build 35375: arc lint + arc unit

Event Timeline

0 edited the test plan for this revision. (Show Details)Sun, Oct 3, 9:51 PM
0 edited the test plan for this revision. (Show Details)
0 retitled this revision from Hide event start times for subsequent days to Hide event start times on subsequent days.Sun, Oct 3, 10:06 PM
0 edited the summary of this revision. (Show Details)
0 edited the test plan for this revision. (Show Details)
0 added a reviewer: epriestley.
0 edited the test plan for this revision. (Show Details)
0 added a project: Calendar.

Reordered getters and setters

0 published this revision for review.Sun, Oct 3, 10:45 PM