Page MenuHomePhabricator
Differential D21725

Hide event start times on subsequent days
Needs ReviewPublic
Actions

Authored by 0 on Oct 3 2021, 9:40 PM.
Tags
Referenced Files
Unknown Object (File)
Wed, Dec 18, 1:55 AM
Unknown Object (File)
Sun, Dec 15, 3:24 PM
Unknown Object (File)
Sun, Dec 15, 10:32 AM
Unknown Object (File)
Fri, Dec 13, 9:22 PM
Unknown Object (File)
Fri, Dec 13, 6:31 AM
Unknown Object (File)
Fri, Dec 6, 8:23 PM
Unknown Object (File)
Fri, Dec 6, 5:29 PM
Unknown Object (File)
Thu, Nov 28, 3:15 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

The start time of a multi-day event is currently displayed on all days, which is misleading. Hide it when showing any day other than the first. Also change the icons to point to the past, making it clear which of the displayed events are continuations of multi-day events.

Test Plan

Looked at events (single- and multi-day, timed and all-day) from several vantage points (before, after):

  • Month View query
    month_before.png (307×1 px, 33 KB)
    month_after.png (307×1 px, 30 KB)
  • Day View query
    day1_before.png (605×460 px, 25 KB)
    day1_after.png (605×460 px, 22 KB)
    day2_before.png (604×460 px, 25 KB)
    day2_after.png (604×460 px, 21 KB)
  • user profile
    week_before.png (324×300 px, 8 KB)
    week_after.png (324×300 px, 7 KB)

Diff Detail

Repository
rP Phabricator
Branch
multiday
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25574
Build 35376: Run Core Tests
Build 35375: arc lint + arc unit

Event Timeline

0 created this revision.Oct 3 2021, 9:40 PM
0 held this revision as a draft.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 3 2021, 9:40 PM
Herald added a subscriber: epriestley. · View Herald Transcript
Harbormaster completed remote builds in B25572: Diff 51774.Oct 3 2021, 9:41 PM
0 updated this revision to Diff 51775.Oct 3 2021, 9:44 PM

Fixed lint errors

Harbormaster completed remote builds in B25573: Diff 51775.Oct 3 2021, 9:45 PM
0 edited the test plan for this revision. (Show Details)Oct 3 2021, 9:51 PM
0 edited the test plan for this revision. (Show Details)
0 retitled this revision from Hide event start times for subsequent days to Hide event start times on subsequent days.Oct 3 2021, 10:06 PM
0 edited the summary of this revision. (Show Details)
0 edited the test plan for this revision. (Show Details)
0 added a reviewer: epriestley.
0 edited the summary of this revision. (Show Details)Oct 3 2021, 10:16 PM
0 edited the test plan for this revision. (Show Details)
0 added a project: Calendar.
0 updated this revision to Diff 51776.Oct 3 2021, 10:41 PM

Reordered getters and setters

Harbormaster completed remote builds in B25574: Diff 51776.Oct 3 2021, 10:42 PM
0 published this revision for review.Oct 3 2021, 10:45 PM
Herald added a subscriber: Korvin. · View Herald TranscriptOct 3 2021, 10:45 PM

Revision Contents
Changeset List

PathSize
src/
applications/
people/
controller/
2 lines
view/
phui/
calendar/
66 lines
3 lines
18 lines

Diff 51776

View Options

src/applications/people/controller/PhabricatorPeopleProfileViewController.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarListView.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarMonthView.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarWeekView.php

Loading...
Phabricator · Built by Phacility