Page MenuHomePhabricator

When creating an inline comment, populate the content state with the default suggestion text
ClosedPublic

Authored by epriestley on Mar 25 2021, 9:07 PM.

Details

Summary

Ref T13559. Currently, the default text for inline comment side-loads in a bizarre way. Instead, when a user creates an inline comment, load the inline context and set it as part of the initial content state.

This allows the side channel (and the code that puts the text in place at the last second on the client) to be removed.

Test Plan

Created inlines, clicked "Suggest Edit". See followup changes.

Diff Detail

Repository
rP Phabricator
Branch
istate9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25329
Build 34973: Run Core Tests
Build 34972: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2021, 4:00 PM
This revision was automatically updated to reflect the committed changes.