Page MenuHomePhabricator
Differential D21652

When creating an inline comment, populate the content state with the default suggestion text
ClosedPublic
Actions

Authored by epriestley on Mar 25 2021, 9:07 PM.
Tags
None
Referenced Files
F15345581: D21652.diff
Mon, Mar 10, 11:32 AM
Unknown Object (File)
Sat, Mar 1, 12:58 PM
Unknown Object (File)
Sun, Feb 23, 7:38 PM
Unknown Object (File)
Sat, Feb 22, 2:37 AM
Unknown Object (File)
Sat, Feb 22, 1:51 AM
Unknown Object (File)
Sat, Feb 22, 1:28 AM
Unknown Object (File)
Thu, Feb 20, 1:01 AM
Unknown Object (File)
Wed, Feb 19, 10:39 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting
Commits
rPb75517918d86: When creating an inline comment, populate the content state with the default…
Summary

Ref T13559. Currently, the default text for inline comment side-loads in a bizarre way. Instead, when a user creates an inline comment, load the inline context and set it as part of the initial content state.

This allows the side channel (and the code that puts the text in place at the last second on the client) to be removed.

Test Plan

Created inlines, clicked "Suggest Edit". See followup changes.

Diff Detail

Repository
rP Phabricator
Branch
istate9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25329
Build 34973: Run Core Tests
Build 34972: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 25 2021, 9:07 PM
Harbormaster completed remote builds in B25329: Diff 51521.Mar 25 2021, 9:08 PM
epriestley requested review of this revision.Mar 25 2021, 9:08 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2021, 4:00 PM
Closed by commit rPb75517918d86: When creating an inline comment, populate the content state with the default… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPb75517918d86: When creating an inline comment, populate the content state with the default….

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
infrastructure/
diff/
17 lines
interface/
13 lines
view/
6 lines
webroot/
rsrc/
js/
application/
diff/
13 lines

Diff 51521

View Options

resources/celerity/map.php

Loading...
View Options

src/infrastructure/diff/PhabricatorInlineCommentController.php

Loading...
View Options

src/infrastructure/diff/interface/PhabricatorInlineComment.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentEditView.php

Loading...
View Options

webroot/rsrc/js/application/diff/DiffInline.js

Loading...
Phabricator · Built by Phacility