Page MenuHomePhabricator

Make the client authoritative for "Save" actions
ClosedPublic

Authored by epriestley on Mar 25 2021, 8:58 PM.

Details

Summary

Ref T13559. When you click "Save" on an inline comment and it's empty, we may actually delete the comment.

Currently, the client and server both make decisions about whether the comment should be deleted. These decisions may not agree, causing the client state to fall out of sync.

Make the client authoritative about whether it wants to handle the user clicking the "Save" button as an intent to save or an intent to delete.

Test Plan

Saved empty and nonempty inlines. See followup changes.

Diff Detail

Repository
rP Phabricator
Branch
istate5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25325
Build 34965: Run Core Tests
Build 34964: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2021, 4:00 PM
This revision was automatically updated to reflect the committed changes.