Use a less-misleading example for Conduit custom constraints
ClosedPublic
Actions

Authored by epriestley on Mar 17 2021, 6:31 PM.

Details

Reviewers: None
Commits: rPff0a4a2c6fce: Use a less-misleading example for Conduit custom constraints

Summary

See PHI2032. The Conduit UI shows some "Example Custom Constraints" that are intended to be generic, but use of "statuses" is misleading since many objects have a status and most of them don't support these specific values.

Make it more clear that these are generic values.

Test Plan

Read new text.

Diff Detail

Repository

rP Phabricator

Branch

conduit1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25305
Build 34932: Run Core Tests
Build 34931: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 17 2021, 6:31 PM

Harbormaster completed remote builds in B25305: Diff 51497.Mar 17 2021, 6:32 PM

epriestley requested review of this revision.Mar 17 2021, 6:32 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 17 2021, 6:47 PM

Closed by commit rPff0a4a2c6fce: Use a less-misleading example for Conduit custom constraints (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPff0a4a2c6fce: Use a less-misleading example for Conduit custom constraints.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

engine/

PhabricatorSearchEngineAPIMethod.php

4 lines

Diff 51497

View Options

src/applications/search/engine/PhabricatorSearchEngineAPIMethod.php

Use a less-misleading example for Conduit custom constraintsClosedPublicActions