Page MenuHomePhabricator

Forbid disabled devices from authenticating via SSH or HTTP
ClosedPublic

Authored by epriestley on Mar 16 2021, 10:41 PM.
Tags
None
Referenced Files
F13260486: D21635.diff
Sun, May 26, 11:58 PM
F13242823: D21635.diff
Thu, May 23, 3:08 AM
F13221181: D21635.diff
Sun, May 19, 2:19 AM
F13203567: D21635.diff
Tue, May 14, 11:53 PM
F13186021: D21635.diff
Sat, May 11, 3:22 AM
Unknown Object (File)
Tue, May 7, 6:07 AM
Unknown Object (File)
Fri, May 3, 3:44 AM
Unknown Object (File)
Wed, May 1, 10:30 PM
Subscribers
None

Details

Summary

Ref T13641. Phabricator sometimes makes intracluster requests that authenticate as a device.

Forbid these requests from authenticating as a disabled device.

Test Plan
  • Ran bin/ssh-exec --phabricator-ssh-device ... as an enabled/disabled device (worked; sensible error).
  • Made Conduit calls as an enable/disabled device (worked; sensible error).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable