Page MenuHomePhabricator

Forbid disabled devices from authenticating via SSH or HTTP
ClosedPublic

Authored by epriestley on Mar 16 2021, 10:41 PM.
Tags
None
Referenced Files
F15560893: D21635.id51496.diff
Tue, Apr 29, 5:08 PM
F15557153: D21635.id.diff
Mon, Apr 28, 8:05 PM
F15553408: D21635.id51496.diff
Mon, Apr 28, 1:55 AM
F15550648: D21635.diff
Sun, Apr 27, 12:51 PM
F15543791: D21635.diff
Sat, Apr 26, 1:06 AM
F15477216: D21635.id51496.diff
Apr 7 2025, 1:00 PM
F15454458: D21635.id51496.diff
Mar 29 2025, 6:35 PM
F15450947: D21635.id51496.diff
Mar 28 2025, 7:14 PM
Subscribers
None

Details

Summary

Ref T13641. Phabricator sometimes makes intracluster requests that authenticate as a device.

Forbid these requests from authenticating as a disabled device.

Test Plan
  • Ran bin/ssh-exec --phabricator-ssh-device ... as an enabled/disabled device (worked; sensible error).
  • Made Conduit calls as an enable/disabled device (worked; sensible error).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable