Page MenuHomePhabricator

Forbid disabled devices from authenticating via SSH or HTTP
ClosedPublic

Authored by epriestley on Mar 16 2021, 10:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 11 2024, 11:34 PM
Unknown Object (File)
Jan 11 2024, 10:24 AM
Unknown Object (File)
Dec 30 2023, 4:28 PM
Unknown Object (File)
Dec 27 2023, 1:47 PM
Unknown Object (File)
Dec 27 2023, 1:47 PM
Unknown Object (File)
Dec 27 2023, 1:47 PM
Unknown Object (File)
Dec 26 2023, 6:43 PM
Unknown Object (File)
Dec 23 2023, 2:29 AM
Subscribers
None

Details

Summary

Ref T13641. Phabricator sometimes makes intracluster requests that authenticate as a device.

Forbid these requests from authenticating as a disabled device.

Test Plan
  • Ran bin/ssh-exec --phabricator-ssh-device ... as an enabled/disabled device (worked; sensible error).
  • Made Conduit calls as an enable/disabled device (worked; sensible error).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable