Page MenuHomePhabricator

Forbid disabled devices from authenticating via SSH or HTTP
ClosedPublic

Authored by epriestley on Mar 16 2021, 10:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 18, 11:32 PM
Unknown Object (File)
Apr 29 2025, 5:08 PM
Unknown Object (File)
Apr 28 2025, 8:05 PM
Unknown Object (File)
Apr 28 2025, 1:55 AM
Unknown Object (File)
Apr 27 2025, 12:51 PM
Unknown Object (File)
Apr 26 2025, 1:06 AM
Unknown Object (File)
Apr 7 2025, 1:00 PM
Unknown Object (File)
Mar 29 2025, 6:35 PM
Subscribers
None

Details

Summary

Ref T13641. Phabricator sometimes makes intracluster requests that authenticate as a device.

Forbid these requests from authenticating as a disabled device.

Test Plan
  • Ran bin/ssh-exec --phabricator-ssh-device ... as an enabled/disabled device (worked; sensible error).
  • Made Conduit calls as an enable/disabled device (worked; sensible error).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable