Page MenuHomePhabricator
Differential D21629

Modernize "mailKey" on AlamnacService
ClosedPublic
Actions

Authored by epriestley on Mar 16 2021, 10:01 PM.
Tags
None
Referenced Files
F15430638: D21629.id.diff
Mon, Mar 24, 8:30 AM
F15428936: D21629.diff
Sun, Mar 23, 11:29 PM
F15427013: D21629.id51477.diff
Sun, Mar 23, 12:14 PM
F15423172: D21629.diff
Sat, Mar 22, 1:37 PM
F15414364: D21629.diff
Thu, Mar 20, 12:12 AM
F15387320: D21629.id.diff
Sat, Mar 15, 2:12 AM
F15321597: D21629.id51477.diff
Thu, Mar 6, 11:06 PM
Unknown Object (File)
Mon, Feb 24, 7:28 PM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13065: Move storage for `mailKey` to the Mail application
T13641: Support "Disabled" devices in Almanac
Commits
rPfadb2bd52b5e: Modernize "mailKey" on AlamnacService
Summary

Ref T13641. Ref T13065. Migrate and drop the onboard "mailKey" column for Almanac Services.

Test Plan

Ran storage migration, got clean report, saw migrated value in mail properties table.

Diff Detail

Repository
rP Phabricator
Branch
almanac5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25285
Build 34904: Run Core Tests
Build 34903: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 16 2021, 10:01 PM
Owners added a subscriber: Restricted Owners Package.Mar 16 2021, 10:01 PM
Harbormaster completed remote builds in B25285: Diff 51477.Mar 16 2021, 10:02 PM
epriestley requested review of this revision.Mar 16 2021, 10:02 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 16 2021, 10:52 PM
Closed by commit rPfadb2bd52b5e: Modernize "mailKey" on AlamnacService (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPfadb2bd52b5e: Modernize "mailKey" on AlamnacService.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
28 lines
2 lines
src/
applications/
almanac/
storage/
10 lines

Diff 51477

View Options

resources/sql/autopatches/20210316.almanac.05.service-mailkey.php

Loading...
View Options

resources/sql/autopatches/20210316.almanac.06.service-dropmailkey.sql

Loading...
View Options

src/applications/almanac/storage/AlmanacService.php

Loading...
Phabricator · Built by Phacility