Differential D21618

Update "AffectedPath" table when a revision's repository changes
ClosedPublic
Actions

Authored by epriestley on Mar 15 2021, 10:47 PM.

Details

Reviewers: None
Maniphest Tasks: T13639: Allow revisions to be queried by affected path via the API
Commits: rP26c68942bd00: Update "AffectedPath" table when a revision's repository changes

Summary

Ref T13639. There's currently a hard-to-hit bug where editing the "Repository" of a revision doesn't update this index.

Instead: update the index on repository change, not just diff update.

Test Plan

Updated a revision, used debug view to see index update.
Changed repository on a revision, used debug view to see index update.

Diff Detail

Repository

rP Phabricator

Branch

recent7

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25262
Build 34870: Run Core Tests
Build 34869: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 15 2021, 10:47 PM

Harbormaster completed remote builds in B25262: Diff 51454.Mar 15 2021, 10:48 PM

epriestley requested review of this revision.Mar 15 2021, 10:48 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 15 2021, 11:16 PM

Closed by commit rP26c68942bd00: Update "AffectedPath" table when a revision's repository changes (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP26c68942bd00: Update "AffectedPath" table when a revision's repository changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

52 lines

Diff 51454

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Update "AffectedPath" table when a revision's repository changesClosedPublicActions