Differential D21610

Clarify the behavior of "audit.can-author-close-audit"
ClosedPublic
Actions

Authored by epriestley on Mar 12 2021, 5:13 PM.

Details

Reviewers: None
Maniphest Tasks: T13631: Support an "auditors" attachment for "diffusion.commit.search"
Commits: rPb11c6fcacd8b: Clarify the behavior of "audit.can-author-close-audit"

Summary

Ref T13631. This option has a behavior other than the behavior implied by the name and documented.

Document the correct behavior, at least. This can likely be removed after T10574.

Test Plan

Read config option help in Config.

Diff Detail

Repository

rP Phabricator

Branch

audit1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25250
Build 34850: Run Core Tests
Build 34849: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 12 2021, 5:13 PM

Harbormaster completed remote builds in B25250: Diff 51443.Mar 12 2021, 5:14 PM

epriestley requested review of this revision.Mar 12 2021, 5:14 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 12 2021, 5:20 PM

Closed by commit rPb11c6fcacd8b: Clarify the behavior of "audit.can-author-close-audit" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPb11c6fcacd8b: Clarify the behavior of "audit.can-author-close-audit".

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

config/

PhabricatorDiffusionConfigOptions.php

12 lines

Diff 51443

View Options

src/applications/diffusion/config/PhabricatorDiffusionConfigOptions.php

Clarify the behavior of "audit.can-author-close-audit"ClosedPublicActions