Interpret search tokens in the for "_..." as substring search
ClosedPublic
Actions

Authored by epriestley on Mar 10 2021, 7:55 PM.

Details

Reviewers: None
Maniphest Tasks: T13632: Compile `_...` search tokens as substring searches
Commits: rP4cff4dc68b6e: Interpret search tokens in the for "_..." as substring search

Summary

Ref T13632. Users searching for __FILE__, etc., almost certainly mean to perform a substring search.

Test Plan

Added tests and made them pass. Searched for various tokens, saw compiler interpretation in UI.

Diff Detail

Repository

rP Phabricator

Branch

stem1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25234
Build 34826: Run Core Tests
Build 34825: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 10 2021, 7:55 PM

Harbormaster completed remote builds in B25234: Diff 51427.Mar 10 2021, 7:56 PM

epriestley requested review of this revision.Mar 10 2021, 7:56 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 10 2021, 8:00 PM

Closed by commit rP4cff4dc68b6e: Interpret search tokens in the for "_..." as substring search (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP4cff4dc68b6e: Interpret search tokens in the for "_..." as substring search.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

compiler/

PhutilSearchQueryCompiler.php

23 lines

__tests__/

PhutilSearchQueryCompilerTestCase.php

14 lines

Diff 51427

View Options

src/applications/search/compiler/PhutilSearchQueryCompiler.php

View Options

src/applications/search/compiler/tests/PhutilSearchQueryCompilerTestCase.php

Interpret search tokens in the for "_..." as substring searchClosedPublicActions