Never return external connections to the GlobalLock connection pool
ClosedPublic
Actions

Authored by epriestley on Mar 2 2021, 9:33 PM.

Details

Reviewers: None
Maniphest Tasks: T13627: Until MySQL 5.7, each MySQL connection may hold only one simultaneous lock
Commits: rP629429b28354: (stable) Never return external connections to the GlobalLock connection pool
rP33bce22ef2ad: Never return external connections to the GlobalLock connection pool

Summary

Ref T13627. If a lock fails, the connection may be returned to the pool, even if the connection is an external connection. Under old versions of MySQL, connection reuse can release other locks on the same connection.

Don't return external connections to the pool.

This issue was introduced in D21369.

Test Plan

Added a failing test and made it pass.

Diff Detail

Repository

rP Phabricator

Branch

lock4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25190
Build 34765: Run Core Tests
Build 34764: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 2 2021, 9:33 PM

Harbormaster completed remote builds in B25190: Diff 51382.Mar 2 2021, 9:34 PM

epriestley requested review of this revision.Mar 2 2021, 9:34 PM

epriestley retitled this revision from Never return external locks to the GlobalLock connection pool to Never return external connections to the GlobalLock connection pool.Mar 2 2021, 9:38 PM

epriestley edited the summary of this revision. (Show Details)