Ref T13608. When searching for bare URIs in remarkup text, don't look for URIs with a protocol string longer than 32 characters.
This avoids a case where the regexp engine may be tricked into executing at O(N^2) or some similar complexity.
Details
Details
- Reviewers
- None
- Maniphest Tasks
- T13608: Remarkup hyperlink pattern may backtrack explosively
- Commits
- rPbd4d9d88f2df: Limit remarkup URI protocol length to 32 characters to avoid expensive regex…
- Applied remarkup to "AAAA..." (512KB).
- Before: 64 seconds to process.
- After: <10ms to process.
- Ran unit tests.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- remarkup1
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 25141 Build 34696: Run Core Tests Build 34695: arc lint + arc unit