Paths

Table of Contentst

Differential D21560

When documents are indexed, record the indexer version (versus the object version) and index epoch
ClosedPublic
Actions

Authored by epriestley on Feb 16 2021, 11:59 PM.

Tags

None

Referenced Files

	F18802671: D21560.diff
	Fri, Oct 17, 7:54 PM

	F18780577: D21560.id51326.diff
	Sun, Oct 12, 5:32 PM

	F18762739: D21560.id51324.diff
	Mon, Oct 6, 8:26 PM

	F18738391: D21560.id51328.diff
	Wed, Oct 1, 3:21 PM

	F18734396: D21560.id.diff
	Tue, Sep 30, 10:53 PM

	F18730247: D21560.diff
	Tue, Sep 30, 12:34 PM

	F18702254: D21560.id.diff
	Sat, Sep 27, 11:26 PM

	F18701325: D21560.diff
	Sat, Sep 27, 6:28 PM

Subscribers

Restricted Owners Package

Details

Reviewers: None
Maniphest Tasks: T13587: Ferret may exhaust AUTO_INCREMENT ID space of "ngrams" table after many reindexes
Commits: rP6703fec3e27d: When documents are indexed, record the indexer version (versus the object…

Summary

Ref T13587. D21495 has significant changes to the ngram indexer, which might possibly contain bugs.

Make it easier to reindex a subset of documents (based on the date when the index was built, and/or the software version which generated the index).

This is in addition to the existing versioning, which is focused on object versions.

Test Plan

Ran bin/search index with various old and new arguments. Spot-checked the IndexVersion table.

Diff Detail

Repository

Branch

defrag2

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php:149	XHP23	Reuse of Iterator Variable
Error	src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php:358	XHP5	Use of Undeclared Variable
Error	src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php:401	PHL1	Unknown Symbol

Unit

Tests Passed

Build Status

Buildable 25134
Build 34684: Run Core Tests
Build 34683: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 16 2021, 11:59 PM

Owners added a subscriber: Restricted Owners Package.Feb 16 2021, 11:59 PM

Harbormaster completed remote builds in B25134: Diff 51324.Feb 17 2021, 12:00 AM

epriestley requested review of this revision.Feb 17 2021, 12:00 AM

Fix typos and bugs, test more "--type" flag values.

Harbormaster completed remote builds in B25135: Diff 51325.Feb 17 2021, 12:04 AM

Correct "bin/index" -> "bin/search index".

Harbormaster completed remote builds in B25136: Diff 51326.Feb 17 2021, 12:07 AM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 17 2021, 12:09 AM

Closed by commit rP6703fec3e27d: When documents are indexed, record the indexer version (versus the object… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP6703fec3e27d: When documents are indexed, record the indexer version (versus the object….

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20210216.index.01.version.sql

2 lines

20210216.index.02.epoch.sql

2 lines

src/

applications/

search/

index/

PhabricatorIndexEngine.php

29 lines

management/

PhabricatorSearchManagementIndexWorkflow.php

323 lines

storage/

PhabricatorSearchIndexVersion.php

8 lines

Diff 51324

resources/sql/autopatches/20210216.index.01.version.sql

Loading...

resources/sql/autopatches/20210216.index.02.epoch.sql

Loading...

src/applications/search/index/PhabricatorIndexEngine.php

Loading...

src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php

Loading...

src/applications/search/storage/PhabricatorSearchIndexVersion.php

Loading...