Annotate the unusual use of "$callback()" in "xsprintf()"
ClosedPublic
Actions

Authored by epriestley on Feb 3 2021, 10:19 PM.

Details

Reviewers: None
Maniphest Tasks: T13588: PHP 8 Compatibility
Commits: rARCc1afa91f9ff8: Annotate the unusual use of "$callback()" in "xsprintf()"

Summary

Ref T13588. See D21500. This syntax is unusual and there are some hidden complexities involved; annotate them. See D21500 for more discussion.

Test Plan

Read text, reviewed D21500.

Repository

rARC Arcanist

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 3 2021, 10:20 PM

epriestley requested review of this revision.

This revision was automatically updated to reflect the committed changes.

Path

Size

src/

xsprintf/

12 lines