Fix ArcanistJSHintLinterTestCase::testLinter for recent JSHint
ClosedPublic
Actions

Authored by jrtc27 on Mon, Jan 11, 3:00 AM.

Details

Reviewers

epriestley
joshuaspence

Group Reviewers

Blessed Reviewers

Commits

rARC09cff8611ba4: Fix ArcanistJSHintLinterTestCase::testLinter for recent JSHint

Summary

Recent JSHint improves the warning and attributes it to the equals sign
rather than the end of the expression (changed in 897e0359ce19, first
released in 2.11.0-rc1).

Test Plan

Ran arc unit with JSHint 2.12.0

Diff Detail

Repository

rARC Arcanist

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jrtc27 created this revision.Mon, Jan 11, 3:00 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMon, Jan 11, 3:00 AM

jrtc27 requested review of this revision.Mon, Jan 11, 3:00 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMon, Jan 11, 3:00 AM

Harbormaster completed remote builds in B24987: Diff 51174.Mon, Jan 11, 3:00 AM

🤷

This revision is now accepted and ready to land.Mon, Jan 11, 3:42 AM

Rebased patch series

Harbormaster completed remote builds in B24996: Diff 51183.Mon, Jan 11, 4:48 AM

Closed by commit rARC09cff8611ba4: Fix ArcanistJSHintLinterTestCase::testLinter for recent JSHint (authored by jrtc27). · Explain WhyMon, Jan 11, 4:51 AM

This revision was automatically updated to reflect the committed changes.

jrtc27 added a commit: rARC09cff8611ba4: Fix ArcanistJSHintLinterTestCase::testLinter for recent JSHint.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

__tests__/

jshint/

expected-conditional.lint-test

2 lines

Diff 51187

View Options

src/lint/linter/tests/jshint/expected-conditional.lint-test

Fix ArcanistJSHintLinterTestCase::testLinter for recent JSHintClosedPublicActions