Page MenuHomePhabricator

Set an explicit height when drawing the dependent revision graph
ClosedPublic

Authored by epriestley on Oct 16 2020, 9:04 PM.
Tags
None
Referenced Files
F17924504: D21481.id51128.diff
Wed, Jul 30, 10:03 AM
F17738685: D21481.id51128.diff
Jul 21 2025, 12:21 AM
F17738430: D21481.id51127.diff
Jul 20 2025, 11:42 PM
F17735924: D21481.diff
Jul 20 2025, 3:43 PM
F17712094: D21481.diff
Jul 17 2025, 9:24 AM
Unknown Object (File)
Jun 5 2025, 5:04 PM
Unknown Object (File)
Jun 3 2025, 12:19 PM
Unknown Object (File)
Apr 29 2025, 9:00 AM
Subscribers
None

Details

Summary

See PHI1900. Recent changes to how commit graphs are drawn made the height automatic in most cases, but it fails in Differential because the element isn't initially visible so the computed height is 0.

Just give them an explicit height so they show up again.

Test Plan

Viewed graphs in Maniphest, Differential, and Diffusion; saw them all render properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Oct 16 2020, 9:10 PM
This revision was automatically updated to reflect the committed changes.