Remove obsolete write to "pid" property in "annihilateProcessGroup()" in Daemon Overseer
ClosedPublic
Actions

Authored by epriestley on Sep 4 2020, 11:39 PM.

Details

Reviewers: None
Maniphest Tasks: T13579: Overseer may fatal when trying to write to "pid" property in "annihilateProcessGroup()"
Commits: rP5fff4ed8dbb7: (stable) Remove obsolete write to "pid" property in "annihilateProcessGroup()"…
rP7daaaa8463e2: Remove obsolete write to "pid" property in "annihilateProcessGroup()" in Daemon…

Summary

Ref T13579. This property was removed in D21425, but I missed this usage site. Remove the assignment; this class no longer tracks the subprocess PID directly.

Test Plan

Searched for "->pid", no further hits.

Diff Detail

Repository

rP Phabricator

Branch

heartbeat1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24869
Build 34310: Run Core Tests
Build 34309: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 4 2020, 11:39 PM

Harbormaster completed remote builds in B24869: Diff 51054.Sep 4 2020, 11:41 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 4 2020, 11:41 PM

epriestley requested review of this revision.

Closed by commit rP7daaaa8463e2: Remove obsolete write to "pid" property in "annihilateProcessGroup()" in Daemon… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP7daaaa8463e2: Remove obsolete write to "pid" property in "annihilateProcessGroup()" in Daemon….

epriestley added a commit: rP5fff4ed8dbb7: (stable) Remove obsolete write to "pid" property in "annihilateProcessGroup()"….Sep 4 2020, 11:44 PM

epriestley mentioned this in T13579: Overseer may fatal when trying to write to "pid" property in "annihilateProcessGroup()".Apr 19 2022, 9:31 PM

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

daemon/

PhutilDaemonHandle.php

1 line

Diff 51054

View Options

src/infrastructure/daemon/PhutilDaemonHandle.php

Remove obsolete write to "pid" property in "annihilateProcessGroup()" in Daemon OverseerClosedPublicActions