Page MenuHomePhabricator

Fix an issue where querying for a large number of projects by slug could paginate incorrectly
ClosedPublic

Authored by epriestley on Jul 9 2020, 5:47 PM.
Tags
None
Referenced Files
F12844696: D21399.diff
Thu, Mar 28, 11:44 PM
F12840328: D21399.id50937.diff
Thu, Mar 28, 8:22 PM
Unknown Object (File)
Jan 20 2024, 4:40 PM
Unknown Object (File)
Jan 16 2024, 4:08 PM
Unknown Object (File)
Jan 16 2024, 12:37 PM
Unknown Object (File)
Jan 12 2024, 4:46 PM
Unknown Object (File)
Jan 1 2024, 5:26 PM
Unknown Object (File)
Dec 28 2023, 4:42 PM
Subscribers
None

Details

Summary

See PHI1809. This query may join the "slug" table, but each project may have multiple slugs, and the query does not "GROUP BY" when this join occurs.

This may lead to partial result sets and unusual paging behavior.

This could likely be caught categorically in loadAllFromArray(); I'll adjust this in a followup.

Test Plan

A minimal reproduction case is something like:

  • Give project P slugs: a, b, c.
  • Give project Q slugs: d.
  • Query for slugs: a, b, c, d; with limit 2.
  • Order the query so P returns first.
  • Expect: P and Q.
  • Actual: P generates 3 raw rows and the final result is just P with no pagination cursor.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable