Page MenuHomePhabricator
Differential D21395

Clean up push failure messaging in "arc land" slightly
ClosedPublic
Actions

Authored by epriestley on Jul 8 2020, 9:13 PM.

Details

Reviewers
None
Commits
rARC3633364bb96f: Clean up push failure messaging in "arc land" slightly
Summary

Ref PHI1808. Currently, push failures are messaged awkwardly. Make this exception handling more selective and the user-facing behavior more readable.

Test Plan

Ran "arc land" against a failing remote, saw a human-readable message instead of a stack trace.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jul 8 2020, 9:13 PM
Harbormaster completed remote builds in B24747: Diff 50928.Jul 8 2020, 9:14 PM
epriestley requested review of this revision.Jul 8 2020, 9:14 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 8 2020, 10:30 PM
Closed by commit rARC3633364bb96f: Clean up push failure messaging in "arc land" slightly (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARC3633364bb96f: Clean up push failure messaging in "arc land" slightly.

Revision Contents
Changeset List

Diff 50931

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/land/engine/ArcanistGitLandEngine.php

Loading...
View Options

src/land/engine/ArcanistLandEngine.php

Loading...
View Options

src/land/engine/ArcanistMercurialLandEngine.php

Loading...
View Options

src/land/exception/ArcanistLandPushFailureException.php

Loading...
Phabricator · Built by Phacility