When "arc land" fails a Mercurial push, actually raise it as an exception
ClosedPublic
Actions

Authored by epriestley on Jul 8 2020, 9:11 PM.

Details

Reviewers: None
Commits: rARC710bceab1031: When "arc land" fails a Mercurial push, actually raise it as an exception

Summary

See PHI1808. Some refactoring of the "passthru" API resulted in error conditinos here being dropped. Instead, raise them as exceptions.

Test Plan

Forced "hg push" to fail, used "arc land" against a failed push, saw error behavior instead of "success" feedback.

Repository

rARC Arcanist

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

epriestley requested review of this revision.Jul 8 2020, 9:11 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 8 2020, 10:30 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

src/

land/

engine/

7 lines