Page MenuHomePhabricator

When "arc land" fails a Mercurial push, actually raise it as an exception
ClosedPublic

Authored by epriestley on Jul 8 2020, 9:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jun 7 2025, 1:44 AM
Unknown Object (File)
Jun 5 2025, 5:02 PM
Unknown Object (File)
May 18 2025, 9:03 PM
Unknown Object (File)
May 18 2025, 9:02 PM
Unknown Object (File)
May 18 2025, 9:02 PM
Unknown Object (File)
Apr 28 2025, 9:57 AM
Unknown Object (File)
Apr 27 2025, 5:27 PM
Unknown Object (File)
Apr 25 2025, 1:27 AM
Subscribers
None

Details

Summary

See PHI1808. Some refactoring of the "passthru" API resulted in error conditinos here being dropped. Instead, raise them as exceptions.

Test Plan

Forced "hg push" to fail, used "arc land" against a failed push, saw error behavior instead of "success" feedback.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jul 8 2020, 10:30 PM
This revision was automatically updated to reflect the committed changes.