When "arc land" fails a Mercurial push, actually raise it as an exception
ClosedPublic
Actions

Authored by epriestley on Jul 8 2020, 9:11 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Jun 7 2025, 1:44 AM

	Unknown Object (File)
	Jun 5 2025, 5:02 PM

	Unknown Object (File)
	May 18 2025, 9:03 PM

	Unknown Object (File)
	May 18 2025, 9:02 PM

	Unknown Object (File)
	May 18 2025, 9:02 PM

	Unknown Object (File)
	Apr 28 2025, 9:57 AM

	Unknown Object (File)
	Apr 27 2025, 5:27 PM

	Unknown Object (File)
	Apr 25 2025, 1:27 AM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rARC710bceab1031: When "arc land" fails a Mercurial push, actually raise it as an exception

Summary

See PHI1808. Some refactoring of the "passthru" API resulted in error conditinos here being dropped. Instead, raise them as exceptions.

Test Plan

Forced "hg push" to fail, used "arc land" against a failed push, saw error behavior instead of "success" feedback.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jul 8 2020, 9:11 PM

Harbormaster completed remote builds in B24746: Diff 50927.Jul 8 2020, 9:11 PM

epriestley requested review of this revision.Jul 8 2020, 9:11 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 8 2020, 10:30 PM

Closed by commit rARC710bceab1031: When "arc land" fails a Mercurial push, actually raise it as an exception (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC710bceab1031: When "arc land" fails a Mercurial push, actually raise it as an exception.

Revision Contents
Changeset List

Path

Size

src/

land/

engine/

ArcanistMercurialLandEngine.php

7 lines

Diff 50930

View Options

src/land/engine/ArcanistMercurialLandEngine.php

When "arc land" fails a Mercurial push, actually raise it as an exceptionClosedPublicActions