Page MenuHomePhabricator

When "arc land" fails a Mercurial push, actually raise it as an exception
ClosedPublic

Authored by epriestley on Wed, Jul 8, 9:11 PM.

Details

Summary

See PHI1808. Some refactoring of the "passthru" API resulted in error conditinos here being dropped. Instead, raise them as exceptions.

Test Plan

Forced "hg push" to fail, used "arc land" against a failed push, saw error behavior instead of "success" feedback.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, Jul 8, 9:11 PM
epriestley requested review of this revision.Wed, Jul 8, 9:11 PM
This revision was not accepted when it landed; it landed in state Needs Review.Wed, Jul 8, 10:30 PM
This revision was automatically updated to reflect the committed changes.